Skip to content

handle review node being null #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chdsbd wants to merge 1 commit into from
+7 −2
Closed

handle review node being null #907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions bot/kodiak/queries/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,9 @@ def get_event_info_query(
asCodeOwner
requestedReviewer {
__typename
... on Bot {
login
}
... on User {
login
}
Expand Down Expand Up @@ -766,9 +769,9 @@ def get_ruleset_rules(*, pull_request: Dict[str, Any]) -> List[RulesetRule]:
return rules


def get_review_requests_dicts(*, pr: Dict[str, Any]) -> List[Dict[str, Any]]:
def get_review_requests_dicts(*, pr: Dict[str, Any]) -> List[Optional[Dict[str, Any]]]:
try:
return cast(List[Dict[str, Any]], pr["reviewRequests"]["nodes"])
return cast(List[Optional[Dict[str, Any]]], pr["reviewRequests"]["nodes"])
except (KeyError, TypeError):
return []

Expand All @@ -779,6 +782,8 @@ def get_requested_reviews(*, pr: Dict[str, Any]) -> List[PRReviewRequest]:
"""
review_requests: List[PRReviewRequest] = []
for request_dict in get_review_requests_dicts(pr=pr):
if request_dict is None:
continue
try:
asCodeOwner = request_dict["asCodeOwner"]
request = request_dict["requestedReviewer"]
Expand Down
Loading