feat(create): add 'copy from existing' (clone) option to CreateComponent by sogladev · Pull Request #3646 · azerothcore/Keira3

sogladev · 2025-12-14T08:11:09Z

Changed proposed:

Add support for cloning an existing entity from the 'Create' card for multiple types.

I modified the tests for create.component.spec.ts. I'm not sure what other tests are needed for this.

FYI not an NX/Angular expert and I used AI tools to help draft this. Hopefully, nothing too bad in here

Details:

Adds allowCopy field to the CreateComponent <keira-create>, which is opt-in.

Handling is done by routing to a /clone route with a provided ID to copy from. This is similar to /select and /create that already exist. The /copy route displays a page with copy queries for the main table and related tables. After executing, the user is routed to the edit page.

After doing this for creatures, it was easy enough to copy and paste the handling for other types.

For gobjects and creatures, only the template-like tables are copied. SmartAI (TODO?), spawns or guid-specific stuff is not copied.

Issues

Closes [Feature Request] - Ability to clone existing entity #25
Closes Suggestion: Data replication #700
Closes Feature Request: Clone/Copy Options #964

UI

UI Screenshots

[[copilot summary below]]

This pull request adds support for "copy" routes and features across multiple entity types in the Keira app, allowing users to duplicate existing entries. It also introduces new internationalized strings related to the copy functionality in all supported languages.

Key changes include:

Routing and Feature Enhancements:

Added new "copy" routes for various entities (e.g., Creature, Quest, Gameobject, Item, Spell, Gossip, GameTele, FishingLoot, MailLoot, ReferenceLoot, PageText, NpcText, AcoreString) in routes.ts, each guarded by the appropriate handler service and linked to the corresponding CopyComponent. This enables users to copy existing records for these entities. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]
Updated imports in routes.ts to include all new CopyComponent classes for the affected features. [1] [2] [3] [4] [5] [6]

Internationalization (i18n):

Added new strings for copy-related UI elements (such as "Copy from existing", "Copy Entry SQL", "Execute", "Continue to Editor", etc.) to all supported language files (en.json, de.json, es.json, fr.json, el.json, it.json). This ensures the new copy functionality is fully localized. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

These changes collectively introduce and localize the experimental ability to copy existing entries for a wide range of entities within the Keira application, improving user productivity and data management.

libs/features/creature/src/creature-copy/creature-copy.component.ts

libs/features/game-tele/src/index.ts

Helias · 2026-01-20T21:14:53Z

libs/features/other-loots/src/spell-loot/spell-loot-copy.component.html

+    [newId]="newId"
+    [relatedTables]="relatedTables"
+  />
+}


I see a lot of duplication code, we could conside to use only one file.html for all 🤔 , are they always the same?

libs/features/other-loots/src/spell-loot/spell-loot-handler.service.ts

libs/shared/db-layer/src/query/mysql-query.service.ts

Helias · 2026-01-20T21:22:59Z

libs/shared/base-editor-components/src/create/create.component.ts

+  }
+  get allowCopy(): boolean {
+    return this._allowCopy;
+  }


Not strictly necessary, I could refactor it a bit later, but I would use signals for this if possible

libs/shared/base-editor-components/src/create/create.component.ts

Helias · 2026-01-20T21:28:11Z

libs/shared/base-editor-components/src/create/create.component.html

+          id="method-blank"
+          value="blank"
+          [(ngModel)]="creationMethod"
+          (change)="onCreationMethodChange()"


we prefer ReactiveFormsModule instead of ngModel and (change), if possible

libs/shared/base-editor-components/src/create/create.component.html

libs/shared/base-editor-components/src/copy-output/copy-output.component.ts

libs/features/texts/src/index.ts

Helias · 2026-01-20T21:41:24Z

It's a big job, it's fantastic 💯 , I left some comments

@input

remove default specify imports remove some imports move select handler logic to shared handler move text to translation file remove 'public' add 'protected' refactor @input to signal, define interface remove 'standalone'

sogladev · 2026-01-24T16:12:47Z

Thanks for the review, I updated it with your suggestions @Helias

I skipped refactoring libs/shared/base-editor-components/src/create/create.component.html to use `ReactiveFormsModule.'

I also did have trouble with abstracting spell-loot-copy.component.html and other *-copy.component.html to some kind of shared component.html. But, I wasn't sure how to pass relatedTables and others to this new component

  templateUrl: '../../../../../libs/shared/base-editor-components/src/copy-output/copy-output.component.html',
  standalone: true,

Helias · 2026-01-25T13:59:38Z

pipeline is failing

sogladev · 2026-01-25T20:29:41Z

test coverage issue. working on it

mock copyRoutePath to allow test to override it

FrancescoBorzi · 2026-03-05T16:43:17Z

libs/shared/base-editor-components/src/copy-output/copy-output.component.ts

+type CopyMode = 'RAW' | 'ALL';
+
+interface RelatedTable {
+  tableName: string;
+  idField: string;
+  copyMode?: CopyMode;
+  columns?: string[];
+}
+
+interface RelatedTableState {
+  tableName: string;
+  idField: string;
+  count: number;
+  included: boolean;
+  copyMode: CopyMode;
+  columns?: string[];
+}


let's try to avoid too big Component classes, these types could be moved to a separate copy-output.model.ts file

FrancescoBorzi · 2026-03-05T16:44:58Z

libs/shared/base-editor-components/src/copy-output/copy-output.component.ts

+    // Navigate to the editor for the newly created entry
+    this.handlerService()!.select(false, this.newId());
+  }
+}


bonus: maybe some of the logic of these methods can be moved to some pure functions or to a service? but not mandatory given that it's not always really doable

FrancescoBorzi · 2026-03-05T16:45:49Z

libs/shared/base-editor-components/src/create/create.component.spec.ts

+  constructor(fixture: ComponentFixture<CreateComponent<TableRow>>) {
+    super(fixture);
+  }
+


no need to override the constructor to just call super

Suggested change

constructor(fixture: ComponentFixture<CreateComponent<TableRow>>) {

super(fixture);

}

FrancescoBorzi · 2026-03-05T16:46:55Z

libs/shared/base-editor-components/src/create/create.component.spec.ts

+  let component: CreateComponent<any>;
+  let fixture: ComponentFixture<CreateComponent<any>>;
+  let page: CreateComponentPage;


please avoid sharing non-immutable variables across tests. Better to have those as const, created inside a setup() function that returns them. Avoid initializing them inside the beforeEach

See how other tests are made. There are still some leftovers that do not respect this pattern, which I'm fixing in another PR.

FrancescoBorzi · 2026-03-05T16:47:11Z

libs/shared/base-editor-components/src/create/create.component.spec.ts

+    fixture = TestBed.createComponent(CreateComponent);
+    component = fixture.componentInstance;
+    // Provide required inputs
+    component.entityTable = 'test';
+    component.entityIdField = 'id';
+    component.customStartingId = 1;
+    component.queryService = fakeQueryService;
+    component.handlerService = fakeHandlerService;
+    fixture.detectChanges();
+    page = new CreateComponentPage(fixture);


these should be moved inside a setup function, see comment above

FrancescoBorzi · 2026-03-05T16:48:27Z

libs/shared/base-editor-components/src/create/create.component.ts

+  protected checkSourceId(): void {
+    if (!this.sourceIdModel) {
+      this.isSourceIdValid = false;
+      this.changeDetectorRef.markForCheck();


It would be better to just use Signals whenever a non-immutable variable is used in the template. This way one does not need to call markForCheck

sogladev mentioned this pull request Dec 14, 2025

feat(trainer): add trainer support #3653

Merged

sogladev marked this pull request as draft January 20, 2026 19:51

feat(create): copy from existing entry

094568c

sogladev marked this pull request as ready for review January 20, 2026 20:29

sogladev force-pushed the dev-copy-from branch from e7d07a1 to 094568c Compare January 20, 2026 20:29