fix(readcomicOnlineli): Resolves #340#344
Open
lmagdanello wants to merge 2 commits intoXonshiz:masterfrom
Open
fix(readcomicOnlineli): Resolves #340#344lmagdanello wants to merge 2 commits intoXonshiz:masterfrom
lmagdanello wants to merge 2 commits intoXonshiz:masterfrom
Conversation
|
Aliás, você acha que a atualização vai passar? O desenvolvedor afirmou que tem outros compromissos que o mantêm longe deste programa. |
Repository owner
deleted a comment from
tabletseeker
Jan 15, 2024
Owner
|
Hey, thanks for raising this change. I'll try to go through this change this weekend and if this works, will merge. 🙏🏽 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed some problems when downloading readcomicOnline.li. I debugged a bit and realized there were some problems:
I analyzed the
full_seriesfunction and noticed that thelisting_tablewas empty. After some testing, I checkedself.appended_headersfrom ReadComicOnlineLi: these additional headers were breaking the connection to the site. I removed some of them and added a way for comic-dl itself to check which platform it is running on (Linux, MacOs, Windows...). This resolved access;After this, I realized that the regex in
single_chapterthat creates the list of comic images had an error. It used double quotes instead of single quotes to filterlstImages.push:With this list of images, I created a function called
beau, insideget_image_links, which is used to decode URLs that have been obfuscated. In the end, it returns a list of image URLs.I ran some tests and verified that the readcomicOnline.li download is working again.
Can you review it?