Allow query conditions on dense array dimensions#2303
Merged
kounelisagis merged 2 commits intomainfrom Mar 6, 2026
Merged
Conversation
4b7dce7 to
62f61c5
Compare
ktsitsi
reviewed
Mar 6, 2026
Contributor
ktsitsi
left a comment
There was a problem hiding this comment.
What happens if the attribute and the dimension have the same id? How is this resolved?
Member
Author
Core's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes Python-side guard that blocked query conditions on dimensions for dense arrays. This was originally added in #722 when Core didn't support QC on dimensions at all. Core has supported this since PR TileDB-Inc/TileDB#3887 but the Python guard was never updated.