fix: nil pointer dereference when RollingUpdate is nil#132
Open
antoinerrr wants to merge 1 commit intoSlinkyProject:mainfrom
Open
fix: nil pointer dereference when RollingUpdate is nil#132antoinerrr wants to merge 1 commit intoSlinkyProject:mainfrom
antoinerrr wants to merge 1 commit intoSlinkyProject:mainfrom
Conversation
antoinerrr
force-pushed
the
fix/nil-rolling-update-strategy
branch
from
2b1dde6 to
bbc04d3
Compare
Author
|
@SkylerMalinowski @vivian-hafener Hi ! Not sure what are the contributing rules, let me know if I need to change anything |
Contributor
|
Good afternoon @antoinerrr, Please modify your PR to follow the default template for new PRs: https://github.com/SlinkyProject/slurm-operator/blob/main/.github/pull_request_template.md Providing testing notes is helpful for reviewers. Testing notes for bug fixes should provide instructions to reproduce a bug on Best regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a nil pointer dereference panic in
splitUpdatePodswhenUpdateStrategy.TypeisRollingUpdatebutUpdateStrategy.RollingUpdateis not set.Breaking Changes
None
Testing Notes
Pretty self explanatory, on main, if you create a nodeset and try to scale it when the update strategy is RollingUpdate but you do not set UpdateStrategy.RollingUpdate.MaxUnavailable variable, it will panic. This PR add a default
Additional Context
None
Fix
Add a nil guard before accessing RollingUpdate.MaxUnavailable. When RollingUpdate is nil, a nil *IntOrString is passed to GetScaledValueFromIntOrPercent, which already handles it by returning the default value (1).