[GeoMechanicsApplication] Make stress state classes more similar#14265
Merged
[GeoMechanicsApplication] Make stress state classes more similar#14265
Conversation
- Added compound assignment and the addition operator to class `PQ`. - Added `noexcept` to several member functions of class `SigmaTau`.
If the addition operation would accidentally swap the components of `Sigma` (or `PQ`), the unit test previously wouldn't catch it. Now it does.
…om a vector expression
It has been replaced by a constructor that receives three `double`s.
github-project-automation
bot
moved this to In progress
in GeoMechanicsApplication (Deltares)
…te-classes-more-similar
markelov208
previously approved these changes
Mar 9, 2026
Contributor
markelov208
left a comment
markelov208
left a comment
There was a problem hiding this comment.
Hi Anne, many thanks for the harmonization. I have only one non-blocking comment.
applications/GeoMechanicsApplication/custom_constitutive/principal_stresses.hpp
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from In progress
to Reviewer approved
in GeoMechanicsApplication (Deltares)
markelov208
approved these changes
Mar 10, 2026
Contributor
markelov208
left a comment
markelov208
left a comment
There was a problem hiding this comment.
Hi Anne, thank you for processing the comment. I think the PR is ready to be merged.
github-project-automation
bot
moved this from 👀 In Review
to ✅ Done
in Kratos Product Backlog
github-project-automation
bot
moved this from Reviewer approved
to Done
in GeoMechanicsApplication (Deltares)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Make stress state classes
PQ,SigmaTauandPrincipalStressesmore similar.🆕 Changelog
noexcept.PQ.