[Mapping] Fix shape function and equation ID evaluation for high-order NURBS in Nearest Element Mapper#14249
Merged
Conversation
juancamarotti
added
C++
FastPR
Member
|
Okay from my side |
philbucher
previously approved these changes
Mar 3, 2026
Member
philbucher
left a comment
philbucher
left a comment
There was a problem hiding this comment.
I suggest to add a unittest for this
Contributor
Author
I added the test now. Thanks for the help :) |
philbucher
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue in the IGA–FEM Nearest Element Mapper related to the evaluation of shape functions and the corresponding equation IDs when using NURBS surfaces with polynomial degree p > 2, inside
projection_utilities.cpp.The bug led to incorrect local support handling in the projection utilities, which resulted in: