[Core] Removing PointsArrayVector explicit cast in geometry#14248
Open
[Core] Removing PointsArrayVector explicit cast in geometry#14248
Conversation
roigcarlo
commented
Mar 2, 2026
|
|
||
| //generate new element by cloning the base one | ||
| Element::Pointer p_element = it->Create(current_id, geom, it->pGetProperties()); | ||
| Element::Pointer p_element = it->Create(current_id, geom.Points(), it->pGetProperties()); |
Member
Author
There was a problem hiding this comment.
For example, cases like this one rely on the casting purely because of the sake of it. The same code could be implemented using a list of nodes directly...
Contributor
There was a problem hiding this comment.
Well, I imagine ppl think that things are implemented for a reason and they can be used so I don't blame them. I really hate how many ambiguous, unnecessary things we define.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
@KratosMultiphysics/technical-committee What we discussed. After going through the code, I believe that 45% of this changes are due to people creating geometries instead of NodeArrays because they did not know that was the argument; 45% of uses that do not care about being a reference or a point and the other 10% legit usages.
Still, i just did a 1:1 translation, but feel free to comment if you believe we could improve the overall code changing the geometry reference to pointer or an actual list of nodes.