[GeoMechanicsApplication] Remove last "geo" beam element#14245
Merged
[GeoMechanicsApplication] Remove last "geo" beam element#14245
Conversation
…shenkoBeamElement2D2N" The new beam element type comes from StructuralMechanicsApplication. Note that the modified tests may or may not be broken now.
The last structural elements have been removed now.
- Use the "TimoshenkoBeamElasticConstitutiveLaw" rather than "BeamConstitutiveLaw". Also the prefix "KratosMultiphysics.StructuralMechanicsApplication" appeared to be redundant. - Added property "AREA_EFFECTIVE_Y". As a result, these (legacy) interface tests pass again.
- Use the "TimoshenkoBeamElasticConstitutiveLaw" rather than "BeamConstitutiveLaw". Also the prefix "KratosMultiphysics.StructuralMechanicsApplication" appeared to be redundant. - Added property "AREA_EFFECTIVE_Y". - For stages 2, 3, and 4, added the process that restores the stresses in the beam from the previous stage. - The tolerance for testing had to be set less strict in order to make the tests pass again.
- Use the "TimoshenkoBeamElasticConstitutiveLaw" rather than "BeamConstitutiveLaw". Also the prefix "KratosMultiphysics.StructuralMechanicsApplication" appeared to be redundant. - Added property "AREA_EFFECTIVE_Y". - Removed properties "I22" and "TORSIONAL_INERTIA" since these are irrelevant to the problem at hand. The analytical calculation now uses "I33" rather than "I22".
- Use the "TimoshenkoBeamElasticConstitutiveLaw" rather than "BeamConstitutiveLaw". Also the prefix "KratosMultiphysics.StructuralMechanicsApplication" appeared to be redundant. - Added property "AREA_EFFECTIVE_Y". - Apparently, for the Timoshenko beam elements, the sign of the bending moment has been changed with respect to the "geo" beam element. That is now taken into account. Also, the Timoshenko beam element for plane strain conditions just has a single component. - When getting the bending moment from the calculation database, use variable "BENDING_MOMENT" (from the StructuralMechanicsApplication) rather than variable "MOMENT" from the Kratos Core.
Also the test directory has been renamed (by removing the "geo_" prefix).
github-project-automation
bot
moved this to In progress
in GeoMechanicsApplication (Deltares)
It was no longer used.
It was no longer used.
rfaasse
reviewed
Mar 2, 2026
Contributor
rfaasse
left a comment
rfaasse
left a comment
There was a problem hiding this comment.
Thanks for removing the geo elements (and related functionality, like the static condensation + RESET_DISPLACEMENT variable), it's nice to see this clean-up!
I have a few minor questions and a suggestion for a minor clarification in one of the README.md files
applications/GeoMechanicsApplication/tests/Interface/base_beam/MaterialParameters.json
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/beam_with_reset_displacement/README.md
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/test_tunnel.gid/ProjectParameters.json
Show resolved
Hide resolved
applications/GeoMechanicsApplication/tests/test_reset_displacement.py
Outdated
Show resolved
Hide resolved
- Corrected the "reset_displacements" flag in stage 3. It is now in agreement with the test documentation (i.e. its value equals `false`). - For stages 1 and 4 we check whether the maximum deflection is within a given relative tolerance of the expected maximum deflection. - For stages 2 and 3, we compare to an absolute tolerance, since no additional deformations occur.
Removed several redundant input parameters.
Also use consistent tolerance values and removed redundant line search parameters.
Blehh... Also updated the documentation a bit more.
rfaasse
approved these changes
Mar 4, 2026
Contributor
rfaasse
left a comment
rfaasse
left a comment
There was a problem hiding this comment.
Thanks for processing the comments, as well as the extra clean-up in the ProjectParameters.json files. Ready to go from my point of view!
github-project-automation
bot
moved this from In progress
to Reviewer approved
in GeoMechanicsApplication (Deltares)
WPK4FEM
approved these changes
Mar 4, 2026
Contributor
WPK4FEM
left a comment
WPK4FEM
left a comment
There was a problem hiding this comment.
Looks like a consistent and hopefully complete removal to me.
Furthermore, the beam with reset displacement now is more comprehensible to me.
Good to go,
Wijtze Pieter
github-project-automation
bot
moved this from Reviewer approved
to Done
in GeoMechanicsApplication (Deltares)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Removed element class
GeoCrBeamElementLinear2D2N, the last "geo" beam element. Users are now supposed to adopt the beam elements from the StructuralMechanicsApplication.🆕 Changelog
GeoCrBeamElementLinear2D2Nas well as utility classGeoStaticCondensationUtility(since it was no longer used).RESET_DISPLACEMENTS, since it was no longer used.LinearTimoshenkoBeamElement2D2N. For these tests, propertyAREA_EFFECTIVE_Yhas been added.ApplyFinalStressesOfPreviousStageToInitialStateto make sure that the stress state is preserved when going from one stage to the next.LinearTimoshenkoBeamElement2D2Nis reversed with respect toGeoCrBeamElementLinear2D2N. Test cases that were checking bending moments now change the sign when comparing the actual values to the expected values. Also, the output item had to be changed fromMOMENTtoBENDING_MOMENT, and when inquiring the latter, there is just a single value rather than multiple components. Furthermore, removed an unused propertyTORSIONAL_INERTIA.I33rather thanI22.