[GeoMechanicsApplication] Added three unit tests for Mohr-Coulomb tension cut off#14234
Open
markelov208 wants to merge 7 commits intomasterfrom
Open
[GeoMechanicsApplication] Added three unit tests for Mohr-Coulomb tension cut off#14234markelov208 wants to merge 7 commits intomasterfrom
markelov208 wants to merge 7 commits intomasterfrom
Conversation
rfaasse
reviewed
Feb 26, 2026
Contributor
rfaasse
left a comment
rfaasse
left a comment
There was a problem hiding this comment.
Hi Gennady, thanks for adding these unit tests, I have a couple suggestions/questions, but nothing major!
...icsApplication/tests/cpp_tests/custom_constitutive/test_mohr_coulomb_with_tension_cutoff.cpp
Show resolved
Hide resolved
...icsApplication/tests/cpp_tests/custom_constitutive/test_mohr_coulomb_with_tension_cutoff.cpp
Outdated
Show resolved
Hide resolved
...icsApplication/tests/cpp_tests/custom_constitutive/test_mohr_coulomb_with_tension_cutoff.cpp
Outdated
Show resolved
Hide resolved
...icsApplication/tests/cpp_tests/custom_constitutive/test_mohr_coulomb_with_tension_cutoff.cpp
Outdated
Show resolved
Hide resolved
...icsApplication/tests/cpp_tests/custom_constitutive/test_mohr_coulomb_with_tension_cutoff.cpp
Show resolved
Hide resolved
...icsApplication/tests/cpp_tests/custom_constitutive/test_mohr_coulomb_with_tension_cutoff.cpp
Outdated
Show resolved
Hide resolved
...icsApplication/tests/cpp_tests/custom_constitutive/test_mohr_coulomb_with_tension_cutoff.cpp
Outdated
Show resolved
Hide resolved
markelov208
commented
Feb 27, 2026
Contributor
Author
markelov208
left a comment
markelov208
left a comment
There was a problem hiding this comment.
Hi Richard, thanks a lot for the review.
...icsApplication/tests/cpp_tests/custom_constitutive/test_mohr_coulomb_with_tension_cutoff.cpp
Show resolved
Hide resolved
...icsApplication/tests/cpp_tests/custom_constitutive/test_mohr_coulomb_with_tension_cutoff.cpp
Show resolved
Hide resolved
...icsApplication/tests/cpp_tests/custom_constitutive/test_mohr_coulomb_with_tension_cutoff.cpp
Outdated
Show resolved
Hide resolved
...icsApplication/tests/cpp_tests/custom_constitutive/test_mohr_coulomb_with_tension_cutoff.cpp
Outdated
Show resolved
Hide resolved
...icsApplication/tests/cpp_tests/custom_constitutive/test_mohr_coulomb_with_tension_cutoff.cpp
Outdated
Show resolved
Hide resolved
...icsApplication/tests/cpp_tests/custom_constitutive/test_mohr_coulomb_with_tension_cutoff.cpp
Outdated
Show resolved
Hide resolved
rfaasse
reviewed
Mar 2, 2026
Contributor
rfaasse
left a comment
rfaasse
left a comment
There was a problem hiding this comment.
Hi Gennady, based on one of my previous suggestions, I think it is actually possible to simplify the tests a bit, but this is minor. If I understand correctly, the actual values (and re-checking after Mohameds fix) are the more important part now, for which it makes more sense to rely on the review by @WPK4FEM or @mnabideltares
...icsApplication/tests/cpp_tests/custom_constitutive/test_mohr_coulomb_with_tension_cutoff.cpp
Outdated
Show resolved
Hide resolved
...icsApplication/tests/cpp_tests/custom_constitutive/test_mohr_coulomb_with_tension_cutoff.cpp
Show resolved
Hide resolved
...icsApplication/tests/cpp_tests/custom_constitutive/test_mohr_coulomb_with_tension_cutoff.cpp
Outdated
Show resolved
Hide resolved
...icsApplication/tests/cpp_tests/custom_constitutive/test_mohr_coulomb_with_tension_cutoff.cpp
Show resolved
Hide resolved
rfaasse
approved these changes
Mar 3, 2026
Contributor
rfaasse
left a comment
rfaasse
left a comment
There was a problem hiding this comment.
No more comments from my side, but probably it makes sense if @WPK4FEM and/or @mnabideltares have a look before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
A brief description of the PR.