Skip to content

[Core] Add GeometryMetricsTensorAdaptor#14208

Merged
sunethwarna merged 5 commits intomasterfrom
core/tensor_adaptors/add_geometry_metrics_ta
Mar 3, 2026
Merged

[Core] Add GeometryMetricsTensorAdaptor#14208
sunethwarna merged 5 commits intomasterfrom
core/tensor_adaptors/add_geometry_metrics_ta

Conversation

@sunethwarna
Copy link
Member

📝 Description
This PR adds GeometryMetricsTensorAdaptor which is able to compute DomainSize of each geometry in the given Geometries, Elements or Conditions container.

Thsi is made such that, it would be easier to extend if someone needs Length, Area, Volume, etc methods in future as well.

🆕 Changelog

  • Adds GeometryMetricsTensorAdaptor
  • Adds unit tests

@RiccardoRossi
Copy link
Member

Just to comment that DomainSize is alrrady exppsed in the geoemtriestensoradaptor

@sunethwarna
Copy link
Member Author

Just to comment that DomainSize is alrrady exppsed in the geoemtriestensoradaptor

Hmm... Is it? I checked, it exposes the Jacobians, but not the domain size straight away. Unless I do the jacobians determinant integration manually, I don't see a way to get the domain size. Am I missing something @RiccardoRossi ?

@RiccardoRossi
Copy link
Member

Just to comment that DomainSize is alrrady exppsed in the geoemtriestensoradaptor

Hmm... Is it? I checked, it exposes the Jacobians, but not the domain size straight away. Unless I do the jacobians determinant integration manually, I don't see a way to get the domain size. Am I missing something @RiccardoRossi ?

i thought it was one of the ones exposed...yet if it is not it is a trivial change to add it ...

@sunethwarna
Copy link
Member Author

sunethwarna commented Feb 18, 2026

@RiccardoRossi We could change the GeometriesTensorAdaptor to have the GP based domain size calculation. But, this will not be exactly the same as the method (or the value) which is used in Geometry::DomainSize method for some geometries. For sensitivity analysis, it is important to be consistent with the forward analysis DomainSize and the adjoint analysis / sensitivity post processing DomainSize computation. Therefore, I would keep this, and could extend the GeometriesTensorAdaptor to support DomainSize, if the need arise. [We have analytical domain size sensitivity computation already implemented for most of the geometries]

Another thing is, all the computations in GeometriesTensorAdaptor currently requires a variable and ProcessInfo. If we put this there, then they should be optional [Not a big issue, but just a small caveat]

@sunethwarna sunethwarna moved this from 👀 Next meeting TODO to 🏗 In progress in Technical Commiittee Feb 18, 2026
@sunethwarna sunethwarna disabled auto-merge February 19, 2026 07:46
@sunethwarna sunethwarna requested a review from matekelemen March 3, 2026 06:23
@sunethwarna sunethwarna enabled auto-merge March 3, 2026 06:23
@sunethwarna
Copy link
Member Author

@matekelemen I addressed your comments, and this is ready for your review.

@sunethwarna sunethwarna merged commit 0f2164a into master Mar 3, 2026
10 checks passed
@sunethwarna sunethwarna deleted the core/tensor_adaptors/add_geometry_metrics_ta branch March 3, 2026 21:41
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Technical Commiittee Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants