refactoring to exclude solver from the base class#14150
refactoring to exclude solver from the base class#14150RiccardoRossi wants to merge 5 commits intomasterfrom
Conversation
|
this is an attempt of the first step of modification of the AnalysisStage base class, to make the Solver optional. a derived class AnalysisStageWithSolver is created to replace the current behaviour and used everywhere so that in principle the current behaviour is unmodified |
|
ok, i am convinced what is now in the PR is 100% compatible with what we had before. the one thing is that there are still two empty "placeholder" calls which we need to reproduce the current behaviour: self.InitializeSolver() #DOES NOTHING in the base class
self.ModifyAfterSolverInitialize() #DOES NOTHING in the base classall the rest is in principle a straightforward change (except obviously that it is now possible to define an AnalysisStage without solver!) |
|
Wouldn't it be easier to add |
|
@rubenzorrilla honestly i think that the solution i am posting here is cleaner |
📝 Description
modifying the base class analysis stage so that it can be run without solver, and defining a derived class "with solver" which replicates the current behaviour