[GeoMechanicsApplication] Add json formatting exception list #14111
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,31 +1,33 @@ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "properties": [ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "model_part_name": "PorousDomain.Soil", | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "properties_id": 1, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "Material": { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "constitutive_law": { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "name": "GeoIncrementalLinearElastic3DLaw" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| }, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "Variables": { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "IGNORE_UNDRAINED": true, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "YOUNG_MODULUS": 1e+04, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "POISSON_RATIO": 0.0, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "DENSITY_SOLID": 2.65, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "DENSITY_WATER": 1.0, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "POROSITY": 0.36, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "BULK_MODULUS_SOLID": 1e+09, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "BULK_MODULUS_FLUID": 1.755e+05, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "PERMEABILITY_XX": 0.1521, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "PERMEABILITY_YY": 0.1521, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "PERMEABILITY_XY": 0.0, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "PERMEABILITY_ZZ": 0.1521, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "PERMEABILITY_YZ": 0.0, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "PERMEABILITY_ZX": 0.0, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "DYNAMIC_VISCOSITY": 9.81, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "BIOT_COEFFICIENT": 1.0, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "RETENTION_LAW": "SaturatedLaw", | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| "SATURATED_SATURATION": 1.0 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+11
to
+28
Contributor
There was a problem hiding this comment. is it possible that to have a rule that aligns the things after the : ? ( for that it would be nice if the font has equal width characters. such that it really aligns )
Suggested change
Further for doubles in scientific notation, I would like if at least the . is present 1e+04 --> 1.e+04 or even nicer 1.0e+04
Contributor
Author
There was a problem hiding this comment. I don't think json writing does the alignment in general. We could have a look how difficult it would be to implement it. For the double in scientific notation, I'll have a look, that shouldn't be difficult
Comment on lines
+11
to
+28
Contributor
There was a problem hiding this comment. Just a question from my side: Why did the previous format need changing in this case?
Contributor
Author
There was a problem hiding this comment. It didn't have to, I just don't know at this point how to make sure the formatting does alignment correctly. The default python json writer doesn't seem to have that option, but we could have a look into how difficult it would be to do so. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| ] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,119 +1,126 @@ | ||||||
| { | ||||||
| "problem_data": { | ||||||
| "problem_name": "apply_initial_uniform_stress_field", | ||||||
| "start_time": 0.0, | ||||||
| "end_time": 1.0, | ||||||
| "echo_level": 1, | ||||||
| "parallel_type": "OpenMP", | ||||||
| "number_of_threads": 1 | ||||||
| }, | ||||||
|
Comment on lines
+3
to
9
Contributor
There was a problem hiding this comment. Also in the ProjectParameters.json files, some alignment after the : would be nice. |
||||||
| "solver_settings": { | ||||||
| "solver_type": "U_Pw", | ||||||
| "model_part_name": "PorousDomain", | ||||||
| "domain_size": 3, | ||||||
| "model_import_settings": { | ||||||
| "input_type": "mdpa", | ||||||
| "input_filename": "single_element" | ||||||
| }, | ||||||
| "material_import_settings": { | ||||||
| "materials_filename": "MaterialParameters.json" | ||||||
| }, | ||||||
| "time_stepping": { | ||||||
| "time_step": 1.0 | ||||||
| }, | ||||||
|
Comment on lines
-24
to
-29
Contributor
There was a problem hiding this comment. Also here the alignment seemed more neat in my opinion... |
||||||
| "buffer_size": 2, | ||||||
| "echo_level": 1, | ||||||
| "clear_storage": false, | ||||||
| "compute_reactions": true, | ||||||
| "move_mesh_flag": false, | ||||||
| "reform_dofs_at_each_step": false, | ||||||
| "block_builder": true, | ||||||
| "solution_type": "Quasi-Static", | ||||||
| "scheme_type": "Newmark", | ||||||
| "reset_displacements": false, | ||||||
| "newmark_beta": 0.25, | ||||||
| "newmark_gamma": 0.5, | ||||||
| "newmark_theta": 0.5, | ||||||
| "strategy_type": "newton_raphson", | ||||||
| "convergence_criterion": "residual_criterion", | ||||||
| "residual_relative_tolerance": 1e-04, | ||||||
|
Contributor
There was a problem hiding this comment. Below is how I always do it. But it's really personal preference...
Suggested change
Contributor
Author
There was a problem hiding this comment. I agree, I'll have a look, shouldn't be too difficult to fix |
||||||
| "residual_absolute_tolerance": 1e-09, | ||||||
| "min_iterations": 6, | ||||||
| "max_iterations": 15, | ||||||
| "number_cycles": 1, | ||||||
| "reduction_factor": 0.5, | ||||||
| "increase_factor": 2.0, | ||||||
| "calculate_reactions": true, | ||||||
| "rotation_dofs": false, | ||||||
| "linear_solver_settings": { | ||||||
| "solver_type": "LinearSolversApplication.sparse_lu", | ||||||
| "scaling": true | ||||||
| }, | ||||||
| "problem_domain_sub_model_part_list": ["Soil"], | ||||||
| "body_domain_sub_model_part_list": ["Soil"] | ||||||
| }, | ||||||
| "output_processes": { | ||||||
| "gid_output": [ | ||||||
| { | ||||||
| "python_module": "gid_output_process", | ||||||
| "kratos_module": "KratosMultiphysics", | ||||||
| "process_name": "GiDOutputProcess", | ||||||
| "Parameters": { | ||||||
| "model_part_name": "PorousDomain.porous_computational_model_part", | ||||||
| "output_name": "output", | ||||||
| "postprocess_parameters": { | ||||||
| "result_file_configuration": { | ||||||
| "gidpost_flags": { | ||||||
| "WriteDeformedMeshFlag": "WriteUndeformed", | ||||||
| "WriteConditionsFlag": "WriteElementsOnly", | ||||||
| "GiDPostMode": "GiD_PostAscii", | ||||||
| "MultiFileFlag": "SingleFile" | ||||||
| }, | ||||||
| "file_label": "step", | ||||||
| "output_control_type": "step", | ||||||
| "output_interval": 1, | ||||||
| "body_output": true, | ||||||
| "node_output": false, | ||||||
| "skin_output": false, | ||||||
| "gauss_point_results": ["CAUCHY_STRESS_VECTOR"] | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
| ] | ||||||
| }, | ||||||
| "processes": { | ||||||
| "constraints_process_list": [ | ||||||
| { | ||||||
| "python_module": "apply_vector_constraint_table_process", | ||||||
| "kratos_module": "KratosMultiphysics.GeoMechanicsApplication", | ||||||
| "process_name": "ApplyVectorConstraintTableProcess", | ||||||
| "Parameters": { | ||||||
| "model_part_name": "PorousDomain.Soil", | ||||||
| "variable_name": "DISPLACEMENT", | ||||||
| "active": [true, true, true], | ||||||
| "is_fixed": [true, true, true], | ||||||
| "value": [0.0, 0.0, 0.0], | ||||||
| "table": [0, 0, 0] | ||||||
| } | ||||||
| }, | ||||||
| { | ||||||
| "python_module": "apply_scalar_constraint_table_process", | ||||||
| "kratos_module": "KratosMultiphysics.GeoMechanicsApplication", | ||||||
| "process_name": "ApplyScalarConstraintTableProcess", | ||||||
| "Parameters": { | ||||||
| "model_part_name": "PorousDomain.Soil", | ||||||
| "variable_name": "WATER_PRESSURE", | ||||||
| "active": true, | ||||||
| "is_fixed": true, | ||||||
| "value": 0.0, | ||||||
| "table": 0 | ||||||
| } | ||||||
| } | ||||||
| ], | ||||||
| "loads_process_list": [ | ||||||
| { | ||||||
| "python_module": "apply_initial_uniform_stress_field", | ||||||
| "kratos_module": "KratosMultiphysics.GeoMechanicsApplication", | ||||||
| "process_name": "ApplyInitialUniformStressField", | ||||||
| "Parameters": { | ||||||
| "model_part_name": "PorousDomain.Soil", | ||||||
| "value": [1.0, 2.0, 3.0, 4.0, 5.0, 6.0] | ||||||
| } | ||||||
| } | ||||||
| ] | ||||||
| } | ||||||
| } | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea of this list is, that we can slowly format the old files by removing a few lines of this exception file, while new jsons will be formatted automatically