Created a faster ingestion mode - pipeline#1750
Merged
imartinez merged 10 commits intozylon-ai:mainfrom Mar 19, 2024
Merged
Conversation
Contributor
|
Published docs preview URL: https://privategpt-preview-a9ccd9ef-0949-4327-a8f2-1b1f816f1bc5.docs.buildwithfern.com |
Contributor
|
Published docs preview URL: https://privategpt-preview-a10c7df0-2c41-46cb-958c-151f09400f61.docs.buildwithfern.com |
This was referenced Mar 17, 2024
Closed
Contributor
|
Published docs preview URL: https://privategpt-preview-2f8403c1-7839-4be4-a483-04a72a181e7c.docs.buildwithfern.com |
imartinez
approved these changes
Mar 19, 2024
Collaborator
imartinez
left a comment
There was a problem hiding this comment.
All I can say is 🙌
Impressive contribution and execution
It is great to have you as a contributor of the project 👏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a faster ingestion mode - pipeline
Configuration
Comparison (mm:ss) Ingesting 434 documents 144Mb all stores are in postgres using ollama for embeddings
Using the
localprofileIn the
parallelingest design, the blocking mutex for the index write causes a bottleneck stalling the embedding computations until the write operation completes. This is particularly problematic because the index is updated per file, exacerbating the slowdown. In contrast, thepipelinedesign adopts a non-blocking approach. Here, all worker data is fed into a single queue, where it accumulates before being written less frequently. This design choice allows for smoother and more efficient processing, as it minimizes the impact of filesystem operations on the overall workflow.Add an ETA logger so you can get an idea how far its gone and when it going to finish
The first log will appear after 30s of ingestion, and then every 60s thereafter.