Skip to content

Comments

Add support for Azure OpenAI#1698

Merged
imartinez merged 6 commits intozylon-ai:mainfrom
olederle:add-azopenai
Mar 15, 2024
Merged

Add support for Azure OpenAI#1698
imartinez merged 6 commits intozylon-ai:mainfrom
olederle:add-azopenai

Conversation

@olederle
Copy link
Contributor

Allows to use Azure OpenAI as LLM and embedding model.

@github-actions
Copy link
Contributor

@olederle olederle marked this pull request as ready for review March 10, 2024 16:03
imartinez
imartinez previously approved these changes Mar 11, 2024
Copy link
Collaborator

@imartinez imartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! As an optional idea, I'd suggest to include this option in the installation docs, both in the list of available options to select and as a recommended setup. https://docs.privategpt.dev/installation/getting-started/installation

@imartinez
Copy link
Collaborator

@olederle please run make check and make test locally. Apparently there are some issues with make check that are preventing the merge.

@SeifBach
Copy link

hey guys just a heads up in the doc [fern/docs/pages/manual/llms.mdx] you guys wrote
api_version: <api_version> # The API version to use. Default is "2023_05_15"
when i tried it it gave me a 404 but worked with dashes instead of underscores 2023-05-15

applied "make check" changes
* mention azopenai as available option and extras
* add recommended section
* include settings-azopenai.yaml configuration file
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@olederle
Copy link
Contributor Author

hey guys just a heads up in the doc [fern/docs/pages/manual/llms.mdx] you guys wrote api_version: <api_version> # The API version to use. Default is "2023_05_15" when i tried it it gave me a 404 but worked with dashes instead of underscores 2023-05-15

That is right. For my use case I have used a preview api_version but want to have a stable version as default. But I introduced a typo with this. This is fixed now.

@olederle
Copy link
Contributor Author

@olederle please run make check and make test locally. Apparently there are some issues with make check that are preventing the merge.

@imartinez This should be fixed now and I have also updated the docs.

@imartinez imartinez merged commit 1efac6a into zylon-ai:main Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants