fix(rules): Turn off default-param-last until it is configurable

Author: evocateur

packages/eslint-config-zillow-base/rules/best-practices.js

@@ -33,7 +33,8 @@ module.exports = {
     'default-case-last': 'error',
 
     // https://eslint.org/docs/rules/default-param-last
-    'default-param-last': 'error',
+    // TODO: enable when it is configurable (breaks valid redux reducers)
+    'default-param-last': 'off',
 
     // encourages use of dot notation whenever possible
     'dot-notation': ['error', { allowKeywords: true }],

packages/eslint-config-zillow-typescript/rules/all-remaining.js

@@ -34,8 +34,9 @@ module.exports = {
     ],
 
     // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/default-param-last.md
+    // TODO: enable when it is configurable (breaks valid redux reducers)
     'default-param-last': 'off',
-    '@typescript-eslint/default-param-last': 'error',
+    '@typescript-eslint/default-param-last': 'off',
 
     // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/dot-notation.md
     'dot-notation': 'off',

packages/eslint-plugin-zillow/test/__snapshots__/eslint-plugin-zillow.test.js.snap

@@ -478,7 +478,7 @@ Object {
       "error",
     ],
     "default-param-last": Array [
-      "error",
+      "off",
     ],
     "dot-location": Array [
       "off",
@@ -3081,7 +3081,7 @@ Object {
           },
         ],
         "zillow/@typescript-eslint/default-param-last": Array [
-          "error",
+          "off",
         ],
         "zillow/@typescript-eslint/dot-notation": Array [
           "error",