Skip to content

Commit 6249318

Browse files
committed
fix(typescript): Turn off react/prop-types in TSX files
1 parent 1ce5bbe commit 6249318

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

packages/eslint-config-zillow-typescript/rules/other-plugin-overrides.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@ module.exports = {
2828
// https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-filename-extension.md
2929
'react/jsx-filename-extension': ['error', { extensions: ['.js', '.jsx', '.tsx'] }],
3030

31+
// TypeScript > prop-types
32+
'react/prop-types': 'off',
33+
3134
// typescript parser doesn't play nicely with react plugin
3235
// https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/sort-comp.md
3336
'react/sort-comp': 'off',

packages/eslint-plugin-zillow/test/__snapshots__/eslint-plugin-zillow.test.js.snap

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3548,6 +3548,9 @@ Object {
35483548
],
35493549
},
35503550
],
3551+
"zillow/react/prop-types": Array [
3552+
"off",
3553+
],
35513554
"zillow/react/sort-comp": Array [
35523555
"off",
35533556
],

0 commit comments

Comments
 (0)