Skip to content

Commit 284dcdd

Browse files
committed
feat: Remove typescript re-export & peer
BREAKING CHANGE: TypeScript config is no longer provided by this module, please switch to eslint-config-zillow-typescript.
1 parent 7d18652 commit 284dcdd

File tree

6 files changed

+2
-592
lines changed

6 files changed

+2
-592
lines changed

packages/eslint-config-zillow-base/README.md

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -34,23 +34,6 @@ Jest-specific rules and environment added to the default export.
3434

3535
Mocha-specific rules and environment added to the default export.
3636

37-
### `"extends": ["zillow-base", "zillow-base/typescript]`
38-
39-
TypeScript-specific rules and environment added to the default export.
40-
41-
This config expects your `tsconfig.json` to be in the current working directory (relative to your eslint config), which is extremely common. If it is elsewhere (say, a monorepo leaf), you will need to override various [`parserOptions`](https://github.com/typescript-eslint/typescript-eslint/blob/master/docs/getting-started/linting/TYPED_LINTING.md):
42-
43-
```js
44-
// .eslintrc.js
45-
module.exports = {
46-
extends: ['zillow-base', 'zillow-base/typescript'],
47-
parserOptions: {
48-
tsconfigRootDir: __dirname,
49-
project: ['./tsconfig.eslint.json', './packages/*/tsconfig.json'],
50-
},
51-
};
52-
```
53-
5437
### `prettier` Editor Plugin Integration
5538

5639
Unfortunately, super-useful editor plugins like `prettier-atom` and `prettier-vscode` do not load Prettier settings from ESLint config, which is where we load our Prettier options from. To workaround this, add a `.prettierrc.js` or `prettier.config.js` file to your repo root with the following content:

packages/eslint-config-zillow-base/package.json

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
"jest.js",
99
"mocha.js",
1010
"prettier.config.js",
11-
"typescript.js",
1211
"rules"
1312
],
1413
"scripts": {
@@ -33,15 +32,12 @@
3332
"node": ">= 10.17"
3433
},
3534
"peerDependencies": {
36-
"@typescript-eslint/eslint-plugin": "^2.29.0",
37-
"@typescript-eslint/parser": "^2.29.0",
3835
"eslint": ">= 5.0.0",
3936
"eslint-plugin-import": "^2.16.0",
4037
"eslint-plugin-jest": "^22.3.0",
4138
"eslint-plugin-mocha": "^5.3.0 || ^6.1.1",
4239
"eslint-plugin-prettier": "^3.0.1",
43-
"prettier": "^2.1.2",
44-
"typescript": "^3.8.3"
40+
"prettier": "^2.1.2"
4541
},
4642
"dependencies": {
4743
"confusing-browser-globals": "^1.0.6",

0 commit comments

Comments
 (0)