fix(plugin): Ensure rendered configs do not contain context-dependent paths

Author: evocateur

packages/eslint-plugin-zillow/lib/get-computed-config.js

@@ -17,5 +17,10 @@ function getComputedConfig(baseConfig) {
     delete computed.filePath;
     delete computed.baseDirectory;
 
+    // un-resolve parser (re-resolved during re-export)
+    if (computed.parser && baseConfig.parser && computed.parser !== baseConfig.parser) {
+        computed.parser = baseConfig.parser;
+    }
+
     return computed;
 }

packages/eslint-plugin-zillow/test/eslint-plugin-zillow.test.js

@@ -3,6 +3,9 @@
 // ensure up-to-date JSON
 require('../lib/render-configs');
 
+const fs = require('fs');
+const path = require('path');
+
 const { configs, processors, rules } = require('..');
 
 describe('eslint-plugin-zillow', () => {
@@ -49,13 +52,25 @@ describe('eslint-plugin-zillow', () => {
                 ],
             },
             recommended: {
-                parser: expect.stringContaining('babel-eslint'),
+                parser: require.resolve('babel-eslint'),
                 rules: {
                     'zillow/react/jsx-indent': ['off', 4],
                     'max-len': ['warn', 100, 4, { ignoreComments: false }],
                     'zillow/import/prefer-default-export': ['off'],
                 },
             },
+            typescript: {
+                overrides: [
+                    {
+                        files: ['**/*.ts?(x)'],
+                        parser: require.resolve('@typescript-eslint/parser'),
+                        plugins: ['zillow'],
+                        rules: {
+                            'zillow/@typescript-eslint/await-thenable': ['error'],
+                        },
+                    },
+                ],
+            },
         });
 
         const importResolverConfig = configs.recommended.settings['import/resolver'];
@@ -103,3 +118,28 @@ describe('eslint-plugin-zillow', () => {
         });
     });
 });
+
+describe('rendered config', () => {
+    // can't use require() because entry mutates those modules :P
+    const readJSON = filePath =>
+        JSON.parse(fs.readFileSync(path.resolve(__dirname, filePath), 'utf8'));
+
+    describe('recommended.json', () => {
+        const renderedConfigRecommended = readJSON('../lib/configs/recommended.json');
+
+        it('has unresolved parser', () => {
+            expect(renderedConfigRecommended).toHaveProperty('parser', 'babel-eslint');
+        });
+    });
+
+    describe('typescript.json', () => {
+        const renderedConfigTypescript = readJSON('../lib/configs/typescript.json');
+
+        it('has unresolved parser', () => {
+            expect(renderedConfigTypescript.overrides[0]).toHaveProperty(
+                'parser',
+                '@typescript-eslint/parser'
+            );
+        });
+    });
+});