Skip to content

Commit eb2ac6d

Browse files
bennetboas-ciicole-millerJosephTLyonskatie-z-geer
committed
acp: Add more logs to model selector to diagnose issue (#36997)
Release Notes: - N/A --------- Co-authored-by: Antonio Scandurra <[email protected]> Co-authored-by: Cole Miller <[email protected]> Co-authored-by: Joseph T. Lyons <[email protected]> Co-authored-by: Katie Geer <[email protected]>
1 parent db5b243 commit eb2ac6d

File tree

3 files changed

+16
-1
lines changed

3 files changed

+16
-1
lines changed

crates/acp_thread/src/connection.rs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,13 @@ impl AgentModelList {
232232
AgentModelList::Grouped(groups) => groups.is_empty(),
233233
}
234234
}
235+
236+
pub fn len(&self) -> usize {
237+
match self {
238+
AgentModelList::Flat(models) => models.len(),
239+
AgentModelList::Grouped(groups) => groups.values().len(),
240+
}
241+
}
235242
}
236243

237244
#[cfg(feature = "test-support")]

crates/agent_ui/src/acp/model_selector.rs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ impl AcpModelPickerDelegate {
7171
let (models, selected_model) = futures::join!(models_task, selected_model_task);
7272

7373
this.update_in(cx, |this, window, cx| {
74-
this.delegate.models = models.ok();
74+
this.delegate.models = models.log_err();
7575
this.delegate.selected_model = selected_model.ok();
7676
this.refresh(window, cx)
7777
})
@@ -141,6 +141,11 @@ impl PickerDelegate for AcpModelPickerDelegate {
141141
cx.spawn_in(window, async move |this, cx| {
142142
let filtered_models = match this
143143
.read_with(cx, |this, cx| {
144+
if let Some(models) = this.delegate.models.as_ref() {
145+
log::debug!("Filtering {} models.", models.len());
146+
} else {
147+
log::debug!("No models available.");
148+
}
144149
this.delegate.models.clone().map(move |models| {
145150
fuzzy_search(models, query, cx.background_executor().clone())
146151
})
@@ -152,6 +157,8 @@ impl PickerDelegate for AcpModelPickerDelegate {
152157
None => AgentModelList::Flat(vec![]),
153158
};
154159

160+
log::debug!("Filtered models. {} available.", filtered_models.len());
161+
155162
this.update_in(cx, |this, window, cx| {
156163
this.delegate.filtered_entries =
157164
info_list_to_picker_entries(filtered_models).collect();

crates/language_model/src/registry.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,7 @@ impl LanguageModelRegistry {
208208
) -> impl Iterator<Item = Arc<dyn LanguageModel>> + 'a {
209209
self.providers
210210
.values()
211+
.filter(|provider| provider.is_authenticated(cx))
211212
.flat_map(|provider| provider.provided_models(cx))
212213
}
213214

0 commit comments

Comments
 (0)