Skip to content

Terminal http links false positives #6226

@rkusa

Description

@rkusa

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

It looks like the http link detection is just checking for the existence of http: or https::

Screenshot 2023-07-20 at 21 04 17

This gets a bit out of hand in certain scenarios:

Screenshot 2023-07-20 at 21 02 12

Because of this, I often open an invalid link while just clicking into the terminal with the intention of moving the focus to it. It is not a big deal, but less false positives would still be nice to have.

Improvements to the detection could be:

  • no non-whitespace before the http
  • extend the pattern to http:// / https:// (assuming it is just http: or https:)

Environment

Zed: v0.95.2 (stable)
OS: macOS 13.4.1
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:integrations/terminalFeedback for terminal integration, shell commands, etcbugDEPRECATED label: use issue type 'Bug' instead

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions