Skip to content

Toggling comments in .heex files or ~H sigils are depricated and the toggled line is removed after saving #6197

@jg70

Description

@jg70

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Toggling comments in Zed via

cmd+ß

leads currently to the following results:

Within .heex files:
# comment

Within ~H sigils in .ex files:
<%# comment %>

Both is deprecated (see https://hexdocs.pm/phoenix_live_view/Phoenix.LiveView.HTMLFormatter.html#module-comments) and the problem is, that such commented lines are automatically removed by the Phoenix.LiveView.Formatter after formatting/saving the file.

Toggling comments should be changed to:
<% # comment %> or <%!-- comment --%>

Environment

Zed: v0.92.4 (stable)
OS: macOS 13.4.1
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

Within ~H sigil in .ex file

Bildschirmfoto 2023-07-02 um 12 44 44

Within .heex file:

Bildschirmfoto 2023-07-02 um 12 45 23

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:languagesAn umbrella label for all programming languages syntax behaviorsarea:languages/elixirElixir programming language supportbugDEPRECATED label: use issue type 'Bug' instead

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions