vim mode: unexpected visual mode

[matgreaves]

Check for existing issues

• Completed

Describe the bug / provide steps to reproduce it

In Vim mode any actions that selects a block of text unexpectedly enters visual mode on next navigation with h, j, k, or l. Interestingly navigating via the arrow keys does not cause this issue.

Reproduction:

1. Select a block of text either with the mouse, or navigation commands such as gd (go to definition).
2. Attempt to move the cursor via h, j, k, or l. The text block will continue to expand.
3. Navigating with up, down, left, or right will clear the selection but on the next navigation via h, j, k, or l the selection will start again from the current cursor.
4. Navigate again with i, j, k, l and a new visual selection will be started.

This is unexpected particularly in the "jump to definition" case as even when closing the new window containing an external definition you're now selecting a visual range.

It is also unexpected that arrow key navigation clears any selection but i, j, k, or l navigation will start a new selected text range.

Environment

Zed: v0.78.1 (stable)
OS: macOS 13.2.0
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

[ConradIrwin]

@Mat-Greaves Thanks for the report! I've fixed many instances of this in recent versions of zed. Please let me know if you still observe them on 0.99 or above.

[matgreaves]

Thanks @ConradIrwin I've noticed most of them seem to be fixed.

One place I still notice this issue is when opening the results of a project search.

Reproduction:

1. In Zed with vim mode enabled open project search with cmd + shift +f
2. Search for something within the opened project and hit enter to search.
3. The buffer opened is in visual mode.

Environment

Zed: v0.99.1 (stable)
OS: macOS 13.3.0
Memory: 32 GiB
Architecture: aarch64

[ConradIrwin]

Thanks @Mat-Greaves! That's strange, I did miss that in the initial round of fixes, but it should still have been fixed by 0.98.

Would you be open to screen-sharing for a few minutes to help me debug?