Skip to content

Commit 1926a05

Browse files
jernejskmripard
authored andcommitted
drm/sun4i: dw-hdmi: Fix max. frequency for H6
It turns out that reasoning for lowering max. supported frequency is wrong. Scrambling works just fine. Several now fixed bugs prevented proper functioning, even with rates lower than 340 MHz. Issues were just more pronounced with higher frequencies. Fix that by allowing max. supported frequency in HW and fix the comment. Fixes: cd90637 ("drm/sun4i: DW HDMI: Lower max. supported rate for H6") Reviewed-by: Chen-Yu Tsai <wens@csie.org> Tested-by: Andre Heider <a.heider@gmail.com> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> Signed-off-by: Maxime Ripard <maxime@cerno.tech> Link: https://patchwork.freedesktop.org/patch/msgid/20210209175900.7092-6-jernej.skrabec@siol.net
1 parent 6a15521 commit 1926a05

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,9 @@ sun8i_dw_hdmi_mode_valid_h6(struct dw_hdmi *hdmi, void *data,
4747
{
4848
/*
4949
* Controller support maximum of 594 MHz, which correlates to
50-
* 4K@60Hz 4:4:4 or RGB. However, for frequencies greater than
51-
* 340 MHz scrambling has to be enabled. Because scrambling is
52-
* not yet implemented, just limit to 340 MHz for now.
50+
* 4K@60Hz 4:4:4 or RGB.
5351
*/
54-
if (mode->clock > 340000)
52+
if (mode->clock > 594000)
5553
return MODE_CLOCK_HIGH;
5654

5755
return MODE_OK;

0 commit comments

Comments
 (0)