Skip to content

Commit 9f68048

Browse files
filmilcommit-bot@chromium.org
authored andcommitted
[vm] Replaces fuchsia.deprecatedtimezone
The FIDL library `fuchsia.deprecatedtimezone` is going away. There are different and better ways to obtain the same functionality. This change removes the dependency on `fuchsia.deprecatedtimezone` from the Dart SDK. Thus setting the stage for the removal of `fuchsia.deprecatedtimezone`. Adds inspect metrics that allow whitebox testing of the runners. Here's a sample `fx iquery` excerpt from a running device, showing a dart runner exposing the same OS diagnostic metrics. Adds support for asynchronous timezone updates, which was missing from previous versions of this commit. ``` dart.cmx: metadata: filename = fuchsia.inspect.Tree component_url = fuchsia-pkg://fuchsia.com/dart_test_debug#meta/dart.cmx timestamp = 12241877209826 payload: root: os: dst_status = 1 get_profile_status = 0 num_get_profile_calls = 1 num_intl_provider_errors = 0 num_on_change_calls = 0 timezone_content_status = 0 tz_data_close_status = -1 tz_data_status = -1 ``` This functionality is guarded by Fuchsia integration tests at //src/tests/intl. Tested: 1. (compile locally for Fuchsia and deploy) ``` fx test //src/tests/intl ``` This runs the specific timezone tests that should break if the functionality itself is broken. 2. Compile dart for Fuchsia and run tests: The instructions are here: dart-lang/sdk@15dfcca I used the instructions above to build and run all tests from `dart_test_debug` package. The tests were ran against the main branch (and then, the tests that failed there were filtered out), then the remaining tests were ran against a Dart version that contains this change. See: - dart-lang/sdk#42245 - dart-lang/sdk#39650 Prior attempts (most recent first): - rolled back as it... didn't compile. It turned out, when building the change with flutter the compilation process has some different settings, so the compilation of the change worked in flutter, but didn't in dart. The compilation error is now fixed, and I ran additional tests: https://dart-review.googlesource.com/c/sdk/+/155582 - rolled back as it had a regression which was not caught by tests. Tests are fixed now at https://fuchsia-review.googlesource.com/c/fuchsia/+/409840 Fixes flutter-team-archive#39650 TEST=See "Tested" section above. Change-Id: Idd78ea42e3ae38dca2ab4c4126e930e53ef8a793 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185302 Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
1 parent 2e2d542 commit 9f68048

2 files changed

Lines changed: 277 additions & 35 deletions

File tree

runtime/vm/BUILD.gn

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ library_for_all_configs("libdart_vm") {
7474
if (is_fuchsia) {
7575
if (using_fuchsia_gn_sdk) {
7676
extra_deps = [
77-
"$fuchsia_sdk_root/fidl/fuchsia.deprecatedtimezone",
77+
"$fuchsia_sdk_root/fidl/fuchsia.intl",
7878
"$fuchsia_sdk_root/pkg/async",
7979
"$fuchsia_sdk_root/pkg/async-default",
8080
"$fuchsia_sdk_root/pkg/async-loop",
@@ -87,7 +87,7 @@ library_for_all_configs("libdart_vm") {
8787
]
8888
} else if (using_fuchsia_sdk) {
8989
extra_deps = [
90-
"$fuchsia_sdk_root/fidl:fuchsia.deprecatedtimezone",
90+
"$fuchsia_sdk_root/fidl:fuchsia.intl",
9191
"$fuchsia_sdk_root/pkg:async-loop",
9292
"$fuchsia_sdk_root/pkg:async-loop-default",
9393
"$fuchsia_sdk_root/pkg:inspect",
@@ -98,9 +98,7 @@ library_for_all_configs("libdart_vm") {
9898
]
9999
} else {
100100
extra_deps = [
101-
# TODO(US-399): Remove time_service specific code when it is no longer
102-
# necessary.
103-
"//sdk/fidl/fuchsia.deprecatedtimezone",
101+
"//sdk/fidl/fuchsia.intl",
104102
"//sdk/lib/sys/cpp",
105103
"//sdk/lib/sys/inspect/cpp",
106104
"//zircon/public/lib/fbl",

0 commit comments

Comments
 (0)