sam/record/data/field/value/base_modifications: Change input to byte string

Author: zaeleus

noodles-sam/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## Unreleased
+
+### Changed
+
+  * sam/record/data/field/value/base_modifications: Change input to byte
+    string.
+
+    This changes the raw input from `&str` to `&[u8]`.
+
 ## 0.81.0 - 2025-12-11
 
 ### Changed

noodles-sam/src/record/data/field/value/base_modifications.rs

@@ -31,7 +31,7 @@ impl BaseModifications {
     /// let is_reverse_complemented = false;
     /// let sequence = Sequence::from(b"CACCCGATGACCGGCT");
     /// let base_modifications = BaseModifications::parse(
-    ///     "C+m,1,3,0;",
+    ///     b"C+m,1,3,0;",
     ///     is_reverse_complemented,
     ///     &sequence,
     /// )?;
@@ -48,11 +48,11 @@ impl BaseModifications {
     /// # Ok::<_, Box<dyn std::error::Error>>(())
     /// ```
     pub fn parse(
-        s: &str,
+        src: &[u8],
         is_reverse_complemented: bool,
         sequence: &Sequence,
     ) -> Result<Self, parser::ParseError> {
-        parser::parse(s, is_reverse_complemented, sequence)
+        parser::parse(src, is_reverse_complemented, sequence)
     }
 }
 

noodles-sam/src/record/data/field/value/base_modifications/parser.rs

@@ -29,12 +29,11 @@ impl fmt::Display for ParseError {
 }
 
 pub(super) fn parse(
-    s: &str,
+    mut src: &[u8],
     is_reverse_complemented: bool,
     sequence: &Sequence,
 ) -> Result<BaseModifications, ParseError> {
     let mut groups = Vec::new();
-    let mut src = s.as_bytes();
 
     while !src.is_empty() {
         let group = parse_group(&mut src, is_reverse_complemented, sequence)
@@ -59,7 +58,7 @@ mod tests {
 
         let is_reverse_complemented = false;
         let sequence = Sequence::from(b"CACCCGATGACCGGCT");
-        let actual = parse("C+m,1,3,0;G-o,2;", is_reverse_complemented, &sequence);
+        let actual = parse(b"C+m,1,3,0;G-o,2;", is_reverse_complemented, &sequence);
 
         let expected = BaseModifications(vec![
             Group::new(