Skip to content

Commit 77939d4

Browse files
Update Node.js GitHub action to use npm lockfile, switch to latest Jaeger UI (jaegertracing#6074)
1 parent ac6f78b commit 77939d4

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed

.github/actions/setup-node.js/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ runs:
1111
- uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
1212
with:
1313
node-version: ${{ env.JAEGER_UI_NODE_JS_VERSION }}
14-
cache: 'yarn'
15-
cache-dependency-path: jaeger-ui/yarn.lock
14+
cache: 'npm'
15+
cache-dependency-path: jaeger-ui/package-lock.json

.github/workflows/ci-docker-hotrod.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ jobs:
3535
with:
3636
go-version: 1.23.x
3737

38+
- uses: ./.github/actions/setup-node.js
39+
3840
- uses: ./.github/actions/setup-branch
3941

4042
- uses: docker/setup-qemu-action@49b3bc8e6bdd4a60e6116a5414239cba5943d3cf # v3.2.0

CONTRIBUTING.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ We gratefully welcome improvements to documentation as well as to code.
1515

1616
### Pre-requisites
1717
* Install [Go](https://golang.org/doc/install) and setup GOPATH and add $GOPATH/bin in PATH
18-
* Install [Yarn](https://yarnpkg.com/) for running local build with the UI
1918

2019
This library uses Go modules to manage dependencies.
2120

scripts/rebuild-ui.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ set -euxf -o pipefail
77

88
cd jaeger-ui
99

10-
git fetch --all --tags
10+
git fetch --all --unshallow --tags
1111
git log --oneline --decorate=full -n 10 | cat
1212

1313
last_tag=$(git describe --tags --dirty 2>/dev/null)
@@ -32,4 +32,4 @@ if [[ "$last_tag" =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
3232
fi
3333

3434
# do a regular full build
35-
yarn install --frozen-lockfile && cd packages/jaeger-ui && yarn build
35+
npm ci && cd packages/jaeger-ui && npm run build

0 commit comments

Comments
 (0)