Rule prop-types includes nextProps checking in shouldComponentUpdate #1690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Feb 19, 2018
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Thanks, this looks great! Could you also add a duplicate test so that one uses babel-eslint, and the other uses the default parser?
…ts. Added a default parser test.
Contributor
Author
|
@ljharb Thanks for your review! I've made the changes requested. |
This was referenced Sep 22, 2018
Closed
This was referenced Nov 23, 2018
1 task
1 task
This was referenced Dec 21, 2018
This was referenced Jan 2, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1684
I've added the
shouldComponentUpdateto the list of functions to include with this rule, following howcomponentWillReceivePropswas implemented.The only thing outstanding are the tests, I've only included a single test but it may need to be put in a different spot.