Skip to content

class DQN uses global variable in assert #494

@DIPOON

Description

@DIPOON

Hello. I'm just student.
I'm not good at English so Excuse me first.

In https://github.com/yandexdataschool/Practical_RL/blob/master/week04_approx_rl/homework_pytorch_main.ipynb, class DQNAgent's forward uses n_actions of global variables as following.
"assert len(
qvalues.shape) == 2 and qvalues.shape[0] == state_t.shape[0] and qvalues.shape[1] == n_actions"
I guess assert should use class private variables
assert len(
qvalues.shape) == 2 and qvalues.shape[0] == state_t.shape[0] and qvalues.shape[1] == **self.**n_actions
It's not important I know.
Just want to check whether my thought is ok...

Thank you!
If you need, tell me my e-mail : [email protected].

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions