Make lexer safer in clo; Remove dead declaration in clg.

Author: davidlion

components/core/src/clp/clg/clg.cpp

@@ -48,19 +48,6 @@ using std::vector;
  * @return true on success, false otherwise
  */
 static bool open_archive(string const& archive_path, Archive& archive_reader);
-/**
- * Searches the archive with the given parameters
- * @param search_strings
- * @param command_line_args
- * @param archive
- * @return true on success, false otherwise
- */
-static bool search(
-        vector<string> const& search_strings,
-        CommandLineArguments& command_line_args,
-        Archive& archive,
-        bool use_heuristic
-);
 /**
  * Opens a compressed file or logs any errors if it couldn't be opened
  * @param file_metadata_ix

components/core/src/clp/clo/clo.cpp

@@ -476,11 +476,11 @@ static bool search_archive(
 
     // Load lexers from schema file if it exists
     auto schema_file_path = archive_path / clp::streaming_archive::cSchemaFileName;
-    unique_ptr<log_surgeon::lexers::ByteLexer> lexer;
+    auto lexer{std::make_unique<log_surgeon::lexers::ByteLexer>()};
     bool use_heuristic = true;
     if (std::filesystem::exists(schema_file_path)) {
         use_heuristic = false;
-        lexer.reset(new log_surgeon::lexers::ByteLexer());
+        lexer = std::make_unique<log_surgeon::lexers::ByteLexer>();
         load_lexer_from_file(schema_file_path.string(), *lexer);
     }