Apply suggestions from code review

Co-authored-by: Bingran Hu <[email protected]>

Author: gibber9809

components/core/src/clp_s/FileWriter.hpp

@@ -32,14 +32,14 @@ class FileWriter {
 
     // Disable copy constructor/assignment operator
     FileWriter(FileWriter const&) = delete;
-    auto operator=(FileWriter const&) -> FileWriter& = delete;
+    [[nodiscard]] auto operator=(FileWriter const&) -> FileWriter& = delete;
 
     // Define custom move constructor/assignment operator
     FileWriter(FileWriter&& writer)
             : m_file{std::exchange(writer.m_file, nullptr)},
               m_fd{std::exchange(writer.m_fd, -1)} {}
 
-    auto operator=(FileWriter&& writer) -> FileWriter& {
+    [[nodiscard]] auto operator=(FileWriter&& writer) -> FileWriter& {
         if (this == &writer) {
             return *this;
         }

components/core/src/clp_s/log_converter/CMakeLists.txt

@@ -1,5 +1,5 @@
 set(
-    CLP_S_CONVERTER_SOURCES
+    CLP_S_LOG_CONVERTER_SOURCES
     CommandLineArguments.cpp
     CommandLineArguments.hpp
     LogConverter.cpp
@@ -12,7 +12,7 @@ if(CLP_BUILD_EXECUTABLES)
     add_executable(
         log-converter
         log_converter.cpp
-        ${CLP_S_CONVERTER_SOURCES}
+        ${CLP_S_LOG_CONVERTER_SOURCES}
     )
     target_compile_features(log-converter PRIVATE cxx_std_20)
     target_link_libraries(

components/core/src/clp_s/log_converter/LogSerializer.hpp

@@ -21,11 +21,11 @@ class LogSerializer {
     // Constructors
     // Disable copy constructor/assignment operator
     LogSerializer(LogSerializer const&) = delete;
-    auto operator=(LogSerializer const&) -> LogSerializer& = delete;
+    [[nodiscard]] auto operator=(LogSerializer const&) -> LogSerializer& = delete;
 
-    // Define default move constructor/assignment operator
+    // Default move constructor/assignment operator
     LogSerializer(LogSerializer&&) noexcept = default;
-    auto operator=(LogSerializer&&) -> LogSerializer& = default;
+    [[nodiscard]] auto operator=(LogSerializer&&) -> LogSerializer& = default;
 
     // Destructor
     ~LogSerializer() = default;