Source cleanup recommendations

Author: bradwilson

src/xunit.runner.visualstudio/Utility/TestCaseFilter.cs

@@ -155,7 +155,7 @@ List<string> GetSupportedPropertyNames()
 		return supportedPropertyNames;
 	}
 
-	static IEnumerable<KeyValuePair<string, string>> GetTraits(TestCase testCase)
+	static KeyValuePair<string, string>[] GetTraits(TestCase testCase)
 	{
 		var traitProperty = TestProperty.Find("TestObject.Traits");
 		if (traitProperty is not null)

src/xunit.runner.visualstudio/VsTestRunner.cs

@@ -172,15 +172,14 @@ public void DiscoverTests(
 			// We can't use await here because the contract from VSTest says we have to wait for everything to finish
 			// before returning from this function.
 			DiscoverTests(
-				sources, loggerHelper, testPlatformContext, runSettings,
+				sources, loggerHelper, runSettings,
 				(source, discoverer, discoveryOptions) => new VsDiscoverySink(source, loggerHelper, discoverySink, discoveryOptions, testPlatformContext, testCaseFilter, () => cancelled)
 			).GetAwaiter().GetResult();
 		}
 
 		async Task DiscoverTests<TVisitor>(
 			IEnumerable<string> sources,
 			LoggerHelper logger,
-			TestPlatformContext testPlatformContext,
 			RunSettings runSettings,
 			Func<string, IFrontControllerDiscoverer, ITestFrameworkDiscoveryOptions, TVisitor> visitorFactory,
 			Action<string, IFrontControllerDiscoverer, ITestFrameworkDiscoveryOptions, TVisitor>? visitComplete = null)
@@ -343,7 +342,7 @@ internal static IRunnerReporter GetRunnerReporter(
 			return reporter ?? new DefaultRunnerReporter();
 		}
 
-		static IList<DiscoveredTestCase> GetVsTestCases(
+		static List<DiscoveredTestCase> GetVsTestCases(
 			string source,
 			VsExecutionDiscoverySink visitor,
 			LoggerHelper logger,
@@ -393,12 +392,11 @@ public void RunTests(
 			RunTests(
 				runContext, frameworkHandle, logger, testPlatformContext, runSettings,
 				() =>
-					tests
+					[.. tests
 						.Distinct(TestCaseUniqueIDComparer.Instance)
 						.GroupBy(testCase => testCase.Source)
 						.Select(group => AssemblyRunInfo.Create(logger, project, runSettings, group.Key, [.. group], runExplicitTests))
-						.WhereNotNull()
-						.ToList()
+						.WhereNotNull()]
 			).GetAwaiter().GetResult();
 		}
 
@@ -428,7 +426,7 @@ public void RunTests(
 			// before returning from this function.
 			RunTests(
 				runContext, frameworkHandle, logger, testPlatformContext, runSettings,
-				() => sources.Select(source => AssemblyRunInfo.Create(logger, project, runSettings, Path.GetFullPath(source))).WhereNotNull().ToList()
+				() => [.. sources.Select(source => AssemblyRunInfo.Create(logger, project, runSettings, Path.GetFullPath(source))).WhereNotNull()]
 			).GetAwaiter().GetResult();
 		}