-
Notifications
You must be signed in to change notification settings - Fork 0
Implement basic Frida JSONL output and parser #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mike-hunhoff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I've left comments for your review. Also, please configure and run our pre-commit hooks by following the steps outlined in https://github.com/mandiant/capa/blob/master/doc/installation.md#install-development-dependencies. This will run our error, style, and format tools.
| yield Arch(capa_arch), NO_ADDRESS | ||
|
|
||
| if process.platform: | ||
| # TODO: capa doesn't have a dedicated FORMAT_ANDROID constant yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add FORMAT_ANDROID in this PR so we won't run into issues later, e.g. using android vs Android in different places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mike-hunhoff Your call though, but do you think "android" is a good name here? another formats are "pe", "elf", "dotnet", don't have similar scope as "android"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point @larchchen , @xukunzh what do you think about FORMAT_FRIDA? This is similar to what we use for VMRay and others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I realized I misunderstood the meaning of FORMAT. The format should represent the file format (like Android's APK, AAB), not the analysis method or platform. My fault.
We should let Frida access the source file to get the format. @mike-hunhoff @larchchen
Co-authored-by: Mike Hunhoff <[email protected]>
Co-authored-by: Mike Hunhoff <[email protected]>
Done:
TODO: