From f886698dc3a3bbebe0e3dab1a17ecf37d968bd77 Mon Sep 17 00:00:00 2001
From: Daniel Imms <tyriar@tyriar.com>
Date: Wed, 6 May 2020 04:53:25 -0700
Subject: [PATCH] Workaround for hover firing multiple times

Fixes #2911
---
 src/browser/Linkifier2.ts | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/src/browser/Linkifier2.ts b/src/browser/Linkifier2.ts
index fb4a028645..f468e4a410 100644
--- a/src/browser/Linkifier2.ts
+++ b/src/browser/Linkifier2.ts
@@ -132,9 +132,16 @@ export class Linkifier2 extends Disposable implements ILinkifier2 {
 
     // There is no link cached, so ask for one
     this._linkProviders.forEach((linkProvider, i) => {
-      const existingReply = this._activeProviderReplies?.get(i);
-      if (existingReply) {
-        linkProvided = this._checkLinkProviderResult(i, position, linkProvided);
+      if (useLineCache) {
+        const existingReply = this._activeProviderReplies?.get(i);
+        // If there isn't a reply, the provider hasn't responded yet.
+
+        // TODO: If there isn't a reply yet it means that the provider is still resolving. Ensuring
+        // provideLinks isn't triggered again saves ILink.hover firing twice though. This probably
+        // needs promises to get fixed
+        if (existingReply) {
+          linkProvided = this._checkLinkProviderResult(i, position, linkProvided);
+        }
       } else {
         linkProvider.provideLinks(position.y, (links: ILink[] | undefined) => {
           if (this._isMouseOut) {