Skip to content

Replace array shift with offset #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2019
Merged

Replace array shift with offset #1956

merged 1 commit into from
Mar 5, 2019

Conversation

@jstolwijk
Copy link
Contributor

@jstolwijk jstolwijk commented Mar 4, 2019

Resolves #1955

Replace array shift with offset

@jstolwijk jstolwijk changed the title Replace array shift with offset (#1955) Replace array shift with offset Mar 4, 2019
Tyriar
Tyriar approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast!

@Tyriar Tyriar added this to the 3.12.0 milestone Mar 5, 2019
@Tyriar Tyriar merged commit 8fa7f17 into xtermjs:master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jstolwijk @Tyriar