Skip to content

fix invalid string and buffer index in Linkifier #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 18, 2018
Merged

fix invalid string and buffer index in Linkifier #1841

merged 3 commits into from
Dec 18, 2018

Conversation

@jerch
Copy link
Member

@jerch jerch commented Dec 17, 2018

Should fix #1840.

@jerch jerch closed this Dec 17, 2018
@jerch jerch reopened this Dec 17, 2018
@Tyriar Tyriar added this to the 3.10.0 milestone Dec 18, 2018
Tyriar
Tyriar approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix 😃

@Tyriar Tyriar merged commit d27b43d into xtermjs:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.10.0

Development

Successfully merging this pull request may close these issues.

Buffer.stringIndexToBufferIndex TypeError: Cannot read property 'length' of undefined

2 participants

@jerch @Tyriar