Skip to content

Conversation

@alexr00
Copy link
Contributor

@alexr00 alexr00 commented Sep 7, 2018

Fixes #1658

@Tyriar Tyriar self-requested a review September 8, 2018 10:03
@Tyriar Tyriar added this to the 3.8.0 milestone Sep 8, 2018
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should eventually do all checks by generating a regex like we talked about but this looks good for now 👍

@Tyriar Tyriar merged commit 5c873c1 into xtermjs:master Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants