Skip to content

Commit e4b50d5

Browse files
authored
Merge pull request #2550 from Tyriar/2549_refresh_options
Refresh rows on options change for all renderers
2 parents b68a4d2 + 22f4342 commit e4b50d5

3 files changed

Lines changed: 1 addition & 2 deletions

File tree

addons/xterm-addon-webgl/src/WebglRenderer.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,6 @@ export class WebglRenderer extends Disposable implements IRenderer {
189189
this._rectangleRenderer.updateSelection(this._model.selection, columnSelectMode);
190190
this._glyphRenderer.updateSelection(this._model, columnSelectMode);
191191

192-
// TODO: #2102 Should this move to RenderCoordinator?
193192
this._onRequestRefreshRows.fire({ start: 0, end: this._terminal.rows - 1 });
194193
}
195194

src/browser/renderer/dom/DomRenderer.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,6 @@ export class DomRenderer extends Disposable implements IRenderer {
340340
// Force a refresh
341341
this._updateDimensions();
342342
this._injectCss();
343-
this._onRequestRefreshRows.fire({ start: 0, end: this._bufferService.rows - 1 });
344343
}
345344

346345
public clear(): void {

src/browser/services/RenderService.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ export class RenderService extends Disposable implements IRenderService {
9595

9696
public changeOptions(): void {
9797
this._renderer.onOptionsChanged();
98+
this.refreshRows(0, this._rowCount - 1);
9899
this._fireOnCanvasResize();
99100
}
100101

0 commit comments

Comments
 (0)