Skip to content

Commit 1c5596d

Browse files
committed
Split up Base64Decoder decoding tests
Fixes #4696
1 parent 9057072 commit 1c5596d

File tree

2 files changed

+16
-19
lines changed

2 files changed

+16
-19
lines changed

addons/xterm-addon-image/src/base64.test.ts

Lines changed: 15 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,9 @@ describe('Base64Decoder', () => {
4545
assert.deepEqual(dec.data8, inp);
4646
}
4747
});
48-
it('1+2 bytes', function() {
49-
this.timeout(20000);
50-
const dec = new Base64Decoder(0);
51-
for (let a = 0; a < 256; ++a) {
48+
for (let a = 0; a < 256; ++a) {
49+
it(`1+2 bytes (${a})`, function() {
50+
const dec = new Base64Decoder(0);
5251
for (let b = 0; b < 256; ++b) {
5352
dec.init(2);
5453
const inp = new Uint8Array([a, b]);
@@ -57,12 +56,11 @@ describe('Base64Decoder', () => {
5756
assert.strictEqual(dec.end(), 0);
5857
assert.deepEqual(dec.data8, inp);
5958
}
60-
}
61-
});
62-
it('2+3 bytes', function() {
63-
this.timeout(20000);
64-
const dec = new Base64Decoder(0);
65-
for (let a = 0; a < 256; ++a) {
59+
});
60+
}
61+
for (let a = 0; a < 256; ++a) {
62+
it(`2+3 bytes (${a})`, function() {
63+
const dec = new Base64Decoder(0);
6664
for (let b = 0; b < 256; ++b) {
6765
dec.init(3);
6866
const inp = new Uint8Array([0, a, b]);
@@ -71,12 +69,11 @@ describe('Base64Decoder', () => {
7169
assert.strictEqual(dec.end(), 0);
7270
assert.deepEqual(dec.data8, inp);
7371
}
74-
}
75-
});
76-
it('3+4 bytes', function() {
77-
this.timeout(20000);
78-
const dec = new Base64Decoder(0);
79-
for (let a = 0; a < 256; ++a) {
72+
});
73+
}
74+
for (let a = 0; a < 256; ++a) {
75+
it(`3+4 bytes (${a})`, function() {
76+
const dec = new Base64Decoder(0);
8077
for (let b = 0; b < 256; ++b) {
8178
dec.init(4);
8279
const inp = new Uint8Array([0, 0, a, b]);
@@ -85,8 +82,8 @@ describe('Base64Decoder', () => {
8582
assert.strictEqual(dec.end(), 0);
8683
assert.deepEqual(dec.data8, inp);
8784
}
88-
}
89-
});
85+
});
86+
}
9087
it('padding', () => {
9188
const dec = new Base64Decoder(0);
9289
const d = fromBs('Hello, here comes the mouse');

src/common/input/TextDecoder.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ describe('text encodings', () => {
5454
assert.equal(utf32ToString(data), s);
5555
});
5656

57-
describe.only('StringToUtf32 decoder', () => {
57+
describe('StringToUtf32 decoder', () => {
5858
describe('full codepoint test', () => {
5959
for (let min = 0; min < 65535; min += BATCH_SIZE) {
6060
const max = Math.min(min + BATCH_SIZE, 65536);

0 commit comments

Comments
 (0)