Skip to content

Commit 754e6d5

Browse files
committed
SignalPathTest: Initialize fields in constructor list
1 parent 05aed0f commit 754e6d5

File tree

1 file changed

+15
-13
lines changed

1 file changed

+15
-13
lines changed

src/test/signalpathtest.h

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -56,19 +56,20 @@ class TestEngineMaster : public EngineMaster {
5656

5757
class BaseSignalPathTest : public MixxxTest {
5858
protected:
59-
BaseSignalPathTest() {
60-
m_pGuiTick = std::make_unique<GuiTick>();
61-
m_pChannelHandleFactory = std::make_shared<ChannelHandleFactory>();
62-
m_pNumDecks = new ControlObject(ConfigKey("[Master]", "num_decks"));
63-
m_pEffectsManager = new EffectsManager(nullptr, config(), m_pChannelHandleFactory);
64-
m_pVisualsManager = new VisualsManager();
65-
m_pEngineMaster = new TestEngineMaster(
66-
m_pConfig,
67-
"[Master]",
68-
m_pEffectsManager,
69-
m_pChannelHandleFactory,
70-
false);
71-
59+
BaseSignalPathTest()
60+
: m_pChannelHandleFactory(std::make_shared<ChannelHandleFactory>()),
61+
m_pNumDecks(new ControlObject(
62+
ConfigKey("[Master]", "num_decks"))),
63+
m_pGuiTick(std::make_unique<GuiTick>()),
64+
m_pVisualsManager(new VisualsManager()),
65+
m_pEffectsManager(new EffectsManager(
66+
nullptr, config(), m_pChannelHandleFactory)),
67+
m_pEngineMaster(new TestEngineMaster(
68+
m_pConfig,
69+
"[Master]",
70+
m_pEffectsManager,
71+
m_pChannelHandleFactory,
72+
false)) {
7273
m_pMixerDeck1 = new Deck(nullptr,
7374
m_pConfig,
7475
m_pEngineMaster,
@@ -233,6 +234,7 @@ class BaseSignalPathTest : public MixxxTest {
233234

234235
VisualsManager* m_pVisualsManager;
235236
EffectsManager* m_pEffectsManager;
237+
236238
EngineSync* m_pEngineSync;
237239
TestEngineMaster* m_pEngineMaster;
238240
Deck *m_pMixerDeck1, *m_pMixerDeck2, *m_pMixerDeck3;

0 commit comments

Comments
 (0)