I've made some pretty good headway in a first implementation of array based API calls on this branch https://github.com/Waqar-ukaea/xdg/tree/GPRT-array-queries. It diverges from the HEAD of PR #94 so I'll wait until that's merged before opening any PRs in relation to this issue. New "batch" prefix ray query calls:

  // Array version of point_in_volume
  virtual void batch_point_in_volume(TreeID tree,
                                     const Position* points,
                                     const Direction* const* directions, // [num_points] array of Direction pointers
                                     const size_t num_points,
                                     uint8_t* results,
                                     std::vector<MeshID>* exclude_primitives = nullptr) const = 0;

  // Array version of ray_fire
  virtual void batch_ray_fire(TreeID tree,
                              const Position* origin,
                              const Direction* direction,
                              const size_t num_rays,
                              double* hitDistances,
                              MeshID* surfaceIDs,
                              const double dist_limit = INFTY,
                              HitOrientation orientation = HitOrientation::EXITING,
                              std::vector<MeshID>* const exclude_primitives = nullptr) = 0;

Couple notes:

Stubs for Embree have been put in place since I've added these at the ray_tracing_interface level - I'm not sure if we will ever want to batch embree calls though.
I've gone for a C-style API here with raw array pointers being passed in and return parameters being populated.
I have a simple test for both batch_point_in_volume() and batch_ray_fire() which essentially takes all of the results from the scalar runs and populates an "expected_results" vector and then runs all of those scalar test_cases in one single batch.
Right now these tests live inside the test_point_in_volume.cpp and test_ray_fire.cpp test cases for GPRT as a final set of assertions over a loop at the end of the test case.
I'm thinking I'll probably define a separate set of test cases to more explicitly test the batch interface but right now these simple tests I have in place are passing so have the first example of launching multiple rays with our GPRTRayTracer class :)
I have put together a batch-ray-fire tool to give me some extra flexibility in debugging/testing. Some outputs shown below (GPRT batched ray fire on the right, Embree single ray-fires on the left:

Array-based ray query interface #72

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions