Skip to content

Commit c4ee9af

Browse files
committed
ci(lint): install system deps so cargo-clippy can build the workspace
poly's cargo-clippy hook builds the whole workspace, and the benchmark harness pulls libheif-sys via xberg's full feature. Ubuntu Noble ships libheif 1.17.6 while libheif-sys needs >= 1.21, so the Lint step failed on a pkg-config error before linting anything. Opts into the new reusable-validate input, which builds libheif 1.23.0 from source.
1 parent 8edb548 commit c4ee9af

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

.github/workflows/ci-lint.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,12 @@ jobs:
159159
uses: xberg-io/actions/.github/workflows/reusable-validate.yml@v1
160160
with:
161161
setup-rust: true
162+
# poly's cargo-clippy hook builds the whole workspace, and
163+
# tools/benchmark-harness depends on xberg with `full`, which pulls
164+
# heic -> xberg-libheif -> libheif-sys. Its build script shells out to
165+
# `pkg-config libheif >= 1.21` and Ubuntu Noble only ships 1.17.6, so
166+
# without this the Lint step dies before linting anything. ~keep
167+
install-system-deps: true
162168
setup-python: true
163169
# poly delegates Elixir formatting to `mix format` when mix is on PATH, and falls
164170
# back to its own built-in Elixir formatter when it is not. The two disagree, so

0 commit comments

Comments
 (0)