-
Notifications
You must be signed in to change notification settings - Fork 235
Open
Labels
module: OCIOptimize Critical ImagesOptimize Critical Imagespriority: mediumIssues which are important, but no one will go out of business.Issues which are important, but no one will go out of business.quick wintype: enhancementImprovements that slightly enhance existing functionality and are fast to implementImprovements that slightly enhance existing functionality and are fast to implement
Milestone
Description
Before submitting an issue please check that you’ve completed the following steps:
- Made sure you’re on the latest version [x]
- Used the search feature to ensure that the bug hasn’t been reported before [x]
Describe the bug
In some case, the LCP element might be the logo if it's too prominent.
If the logo is changed, and OCI has been already generated, WP Rocket will keep preloading the wrong LCP image.
To Reproduce
Steps to reproduce the behavior:
- Make the logo big enough to be the LCP element
- Generate OCI
- Change the logo
- See error
Expected behavior
Though it's not generally expected for the logo to be the LCP element, but it might happen.
We need to track logo changes, at least on the Customizer, and clear rows on OCI where it's being used as the LCP element.
Screenshots
N/A
Additional context
N/A
Acceptance Criteria (for WP Media team use only)
- On logo change, check if it's used on OCI
- If yes, clear all
- If no, do nothing
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
module: OCIOptimize Critical ImagesOptimize Critical Imagespriority: mediumIssues which are important, but no one will go out of business.Issues which are important, but no one will go out of business.quick wintype: enhancementImprovements that slightly enhance existing functionality and are fast to implementImprovements that slightly enhance existing functionality and are fast to implement