fix(cli): use fs.symlinkSync for paths with spaces, show version in status (#833)

* fix(cli): use fs.symlinkSync for paths with spaces, show version in status

Replace shell `ln -fs` with Node.js fs.symlinkSync to handle paths
containing spaces. Extract nttVersion() into shared version.ts and
print CLI version in `ntt status` output.

* style: run prettier on changed files

* fix(cli): guard against malformed version file

* fix(cli): improve version check and add end-to-end symlink test

Use nttVersion() null check instead of string comparison in index.ts.
Replace source-level symlink assertion with an end-to-end test that
exercises createWorkTree in a temp repo with spaces in the path.

* style: run prettier on test file

Author: evgeniko

cli/src/__tests__/bugfix-regression.test.ts

@@ -1,7 +1,10 @@
 import { describe, expect, test, spyOn, beforeEach, afterEach } from "bun:test";
+import { execSync } from "child_process";
 import fs from "fs";
+import os from "os";
 import path from "path";
 import { checkConfigErrors } from "../configErrors";
+import { createWorkTree } from "../tag";
 import { validateChain } from "../validation";
 
 const SRC_DIR = path.resolve(import.meta.dir, "..");
@@ -189,6 +192,41 @@ describe("Fix #14: sui/helpers.ts — execFileSync only, no execSync", () => {
   });
 });
 
+// ─── tag.ts — symlink creation handles spaces in path ────────────────────────
+
+describe("tag.ts — symlink creation with spaces in cwd", () => {
+  test("createWorkTree creates overrides.json symlink to the source file", () => {
+    const originalCwd = process.cwd();
+    const tempRoot = fs.mkdtempSync(
+      path.join(os.tmpdir(), "ntt-symlink-test-")
+    );
+    const repoDir = path.join(tempRoot, "dir with spaces");
+    fs.mkdirSync(repoDir);
+
+    try {
+      process.chdir(repoDir);
+      execSync("git init -q");
+      execSync("git config user.email [email protected]");
+      execSync("git config user.name test");
+      fs.writeFileSync("overrides.json", "{}\n");
+      execSync("git add overrides.json");
+      execSync("git -c commit.gpgsign=false commit -qm init");
+      execSync("git tag v1.2.3+evm");
+
+      const worktree = createWorkTree("Evm", "1.2.3");
+      const symlinkPath = path.resolve(worktree, "overrides.json");
+
+      expect(fs.lstatSync(symlinkPath).isSymbolicLink()).toBe(true);
+
+      const symlinkTarget = fs.readlinkSync(symlinkPath);
+      expect(path.resolve(symlinkTarget)).toBe(path.resolve("overrides.json"));
+    } finally {
+      process.chdir(originalCwd);
+      fs.rmSync(tempRoot, { recursive: true, force: true });
+    }
+  });
+});
+
 // ─── Fix #11: config-mgmt.ts — no contradictory ?. + ! ──────────────────────
 
 describe("Fix #11: config-mgmt.ts — no diff[k]?.push! pattern", () => {

cli/src/commands/status.ts

@@ -23,6 +23,7 @@ import {
   getImmutables,
   getPdas,
 } from "../index";
+import { formatNttVersion } from "../version.js";
 
 export function createStatusCommand(
   overrides: WormholeConfigOverrides<Network>
@@ -44,6 +45,8 @@ export function createStatusCommand(
           "Check the status with detailed output"
         ),
     handler: async (argv: any) => {
+      console.log(formatNttVersion());
+
       const path = argv["path"];
       const verbose = argv["verbose"];
       // TODO: I don't like the variable names here

cli/src/index.ts

@@ -2,7 +2,6 @@
 import "./side-effects"; // doesn't quite work for silencing the bigint error message. why?
 import type { Network } from "@wormhole-foundation/sdk-connect";
 import type { WormholeConfigOverrides } from "@wormhole-foundation/sdk-connect";
-import fs from "fs";
 import yargs from "yargs";
 import { hideBin } from "yargs/helpers";
 import { register as registerEvm } from "@wormhole-foundation/sdk-evm-ntt";
@@ -32,6 +31,7 @@ import {
   createUpgradeCommand,
 } from "./commands";
 import { loadOverrides } from "./overrides.js";
+import { formatNttVersion, nttVersion } from "./version.js";
 
 // TODO: check if manager can mint the token in burning mode (on solana it's
 // simple. on evm we need to simulate with prank)
@@ -42,20 +42,8 @@ yargs(hideBin(process.argv))
   .scriptName("ntt")
   .version(
     (() => {
-      const ver = nttVersion();
-      if (!ver) {
-        return "unknown";
-      }
-      const { version, commit, path, remote } = ver;
-      const defaultPath = `${process.env.HOME}/.ntt-cli/.checkout`;
-      const remoteString = remote.includes("wormhole-foundation")
-        ? ""
-        : `${remote}@`;
-      if (path === defaultPath) {
-        return `ntt v${version} (${remoteString}${commit})`;
-      } else {
-        return `ntt v${version} (${remoteString}${commit}) from ${path}`;
-      }
+      if (!nttVersion()) return "unknown";
+      return formatNttVersion();
     })()
   )
   // Commands (extracted to individual files in commands/)
@@ -80,22 +68,6 @@ yargs(hideBin(process.argv))
   .demandCommand()
   .parse();
 
-function nttVersion(): {
-  version: string;
-  commit: string;
-  path: string;
-  remote: string;
-} | null {
-  const nttDir = `${process.env.HOME}/.ntt-cli`;
-  try {
-    const versionFile = fs.readFileSync(`${nttDir}/version`).toString().trim();
-    const [commit, installPath, version, remote] = versionFile.split("\n");
-    return { version, commit, path: installPath, remote };
-  } catch {
-    return null;
-  }
-}
-
 // ── Re-exports for backward compatibility ────────────────────────────
 // Commands import from "../index" — keep these re-exports so nothing breaks.
 

cli/src/tag.ts

@@ -1,6 +1,7 @@
 import type { Platform } from "@wormhole-foundation/sdk";
 import { execSync } from "child_process";
 import fs from "fs";
+import path from "path";
 import { colors } from "./colors.js";
 import { askForConfirmation } from "./prompts.js";
 
@@ -83,12 +84,14 @@ export function createWorkTree(platform: Platform, version: string): string {
 
   // NOTE: we create this symlink whether or not the file exists.
   // this way, if it's created later, the symlink will be correct
-  execSync(
-    `ln -fs $(pwd)/overrides.json $(pwd)/${worktreeName}/overrides.json`,
-    {
-      stdio: "inherit",
-    }
-  );
+  const target = path.resolve("overrides.json");
+  const linkPath = path.resolve(worktreeName, "overrides.json");
+  try {
+    fs.unlinkSync(linkPath);
+  } catch (e: any) {
+    if (e.code !== "ENOENT") throw e;
+  }
+  fs.symlinkSync(target, linkPath);
 
   console.log(
     colors.green(`Created worktree at ${worktreeName} from tag ${tag}`)

cli/src/version.ts

@@ -0,0 +1,36 @@
+import fs from "fs";
+
+export function nttVersion(): {
+  version: string;
+  commit: string;
+  path: string;
+  remote: string;
+} | null {
+  const nttDir = `${process.env.HOME}/.ntt-cli`;
+  try {
+    const versionFile = fs.readFileSync(`${nttDir}/version`).toString().trim();
+    const parts = versionFile.split("\n");
+    if (parts.length < 4) return null;
+    const [commit, installPath, version, remote] = parts;
+    return { version, commit, path: installPath, remote };
+  } catch {
+    return null;
+  }
+}
+
+export function formatNttVersion(): string {
+  const ver = nttVersion();
+  if (!ver) {
+    return "ntt version: unknown";
+  }
+  const { version, commit, path, remote } = ver;
+  const defaultPath = `${process.env.HOME}/.ntt-cli/.checkout`;
+  const remoteString = remote.includes("wormhole-foundation")
+    ? ""
+    : `${remote}@`;
+  if (path === defaultPath) {
+    return `ntt v${version} (${remoteString}${commit})`;
+  } else {
+    return `ntt v${version} (${remoteString}${commit}) from ${path}`;
+  }
+}