[3단계 - 페이먼츠] 유세지(김용래) 미션 제출합니다. #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinpark420
approved these changes
May 31, 2022
austinpark420
left a comment
austinpark420
left a comment
There was a problem hiding this comment.
안녕하세요 유세지 😄
여러가지 일정도 있고 학습할 공부분량도 많고 많이 힘드시죠 ㅠㅠ
지치지말고 화이팅하시면 나중에 좋은 결과 있을거에요!!
이번 미션은 머지하도록 할게요.
고생많으셨습니다 👍
| height: 130px; | ||
| background: ${(props) => props.backgroundColor || "#D2D2D2"}; | ||
| background: ${(props) => props.backgroundColor || COLORS.WHITE_200}; |
| @@ -0,0 +1,35 @@ | |||
| interface card { | |||
There was a problem hiding this comment.
interface, type 첫문자는 보통 대문자로 작성합니다!~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 오스틴!
step3로 다시 만나게 되어 반갑습니다 😊
이번 step은 요구사항 충족과 피드백이 필수가 아닌 것으로 알고 있어요!
그럼에도 꼭 완료하고 싶었지만 개인 일정과 다른 일들이 겹치다보니
타입스크립트 학습도 충분하지 않고.. 만족할 수준으로 미션을 수행해서 제출하지 못했네요 😥
오스틴이 이전에 해주셨던 피드백과 새로 학습하는 공포의 타입스크립트를 바탕으로...
미션이 끝나고 나서도 계속 리팩토링하며 개인적인 학습을 이어가도록 하겠습니다!
오늘도 좋은 하루 되시길 바랄게요! 😄
필수 요구사항
common컴포넌트를 TS로 변환 하였습니다.