-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Cherry pick mulifix #4595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry pick mulifix #4595
Conversation
- also wait for strip before updating segment
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@DedeHai @willmmiles @netmindz did anyone have a look? Or should we just merge as-is? |
|
I did glance over it, nothing did stand out to me. Since this is a back-port of working fixes and all envs compile fine I would assume its good to go. |
Cherry pick mulifix
Backported fixes for bugs encountered in 0.15
Subset of #4568 - see that issue for more details of what was pulled in