Fx scrolling text more flexible date and time #4195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to nonbreaking change and auto uppercasing according to review.
Collaborator
|
@5chubrakete since you are working on this part of the code: can you check if #4197 is easy to fix? |
Contributor
Author
okay |
DedeHai
reviewed
Oct 17, 2024
| else if (!strncmp_P(text,PSTR("#HHMM"),5)) sprintf_P(text, zero?PSTR("%02d:%02d") :PSTR("%d:%02d"), AmPmHour, minute(localTime)); | ||
| else if (!strncmp_P(text,PSTR("#HH"),3)) sprintf_P(text, zero?PSTR("%02d") :PSTR("%d"), AmPmHour); | ||
| else if (!strncmp_P(text,PSTR("#MM"),3)) sprintf_P(text, zero?PSTR("%02d") :PSTR("%d"), minute(localTime)); | ||
| else if (!strncmp_P(text,PSTR("#HH"),3)) sprintf (text, zero? ("%02d") : ("%d"), AmPmHour); |
Collaborator
There was a problem hiding this comment.
repeated many times but using only 5 bytes. saves flash at small expense of RAM
Collaborator
|
@5chubrakete please add entries for added templates to WLED-Docs. It can be merged after that PR is done. |
Contributor
Author
|
done. WLED-Doc #231 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some date and time formatting options to scrolling text effect.
Updated to nonbreaking change and auto uppercasing according to review.
This is a rebased pull request for #4192