-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Copy Segment FX #4124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Copy Segment FX #4124
Changes from 14 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
434ba3f
Added FX to copy a segment in 1D or 2D
DedeHai 24df6bf
Added copying source settings
DedeHai 696f74b
Update integrating new ideas as discussed
DedeHai 1e0ceab
Merge remote-tracking branch 'upstream/0_15' into 0_15_copy_segment
DedeHai 8aa82ab
fixes and optimizations
DedeHai dd8353a
moved getRenderedPixelXY() into SEGMENT class, plus little improvement
DedeHai bdd8747
Merge remote-tracking branch 'upstream/0_15' into 0_15_copy_segment
DedeHai df33a36
rgb2hsv now returns the CHSV value instead of using a reference
DedeHai 7db1adc
added forgotten returnvalue
DedeHai 24a424a
Moved getRenderedPixelXY to WS2812FX class and changed segment access
DedeHai a5807b5
Added HSV2RGB and RGB2HSV functions for higher accuracy conversions
DedeHai 6d3457f
Merge remote-tracking branch 'upstream/main' into 0_15_copy_segment
DedeHai f2c24ca
added overlay option, renamed slider
DedeHai d487d14
Merge remote-tracking branch 'upstream/main' into 0_15_copy_segment
DedeHai e63bea2
Merge remote-tracking branch 'upstream/main' into 0_15_copy_segment
DedeHai 1db5f32
update to work with layering
DedeHai 2d44e08
remove comment
DedeHai b161405
Merge branch 'main' into 0_15_copy_segment
DedeHai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since CHSV32 is custom HSV class, I would suggest to incorporate constructor from RGBW32 and
uint32_twhich should hide explicit calls to HSV conversion.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
constructor is implemented in #4615 but it uses the fastled equivalent "rainbow" conversion for nicer colors, however, here we want the technically correct spectrum conversion to avoid color shifts.