bugfixes

Author: DedeHai

wled00/FX.cpp

@@ -5695,7 +5695,7 @@ uint16_t mode_2DSunradiation(void) {                   // By: ldirko https://edi
   uint8_t someVal = SEGMENT.speed/4;             // Was 25.
   for (int j = 0; j < (rows + 2); j++) {
     for (int i = 0; i < (cols + 2); i++) {
-      byte col = ((int16_t)perlin8(i * someVal, j * someVal, t) - 0x7F) / 3;
+      byte col = ((int16_t)perlin8(i * someVal, j * someVal, t) - 127) >> 2; // about +/- 32
       bump[index++] = col;
     }
   }

wled00/colors.h

@@ -19,6 +19,7 @@ class CRGBPalette16;
 uint8_t scale8(uint8_t i, uint8_t scale);
 uint8_t qadd8(uint8_t i, uint8_t j);
 uint8_t qsub8(uint8_t i, uint8_t j);
+uint8_t qmul8(uint8_t i, uint8_t j);
 int8_t abs8(int8_t i);
 
 typedef uint32_t TProgmemRGBPalette16[16];
@@ -306,15 +307,9 @@ struct CRGB {
 
   // multiply each of the channels by a constant, saturating each channel at 0xFF.
   inline CRGB& operator*= (uint8_t d) {
-    unsigned red = (unsigned)r * (unsigned)d;
-    unsigned green = (unsigned)r * (unsigned)d;
-    unsigned blue = (unsigned)r * (unsigned)d;
-    if(red > 255) red = 255;
-    if(green > 255) green = 255;
-    if(blue > 255) blue = 255;
-    r = red;
-    g = green;
-    b = blue;
+    r = qmul8(r, d);
+    g = qmul8(g, d);
+    b = qmul8(b, d);
     return *this;
   }
 

wled00/fcn_declare.h

@@ -494,6 +494,7 @@ __attribute__ ((always_inline)) inline uint8_t  scale8_video(uint8_t i, uint8_t
 __attribute__ ((always_inline)) inline uint16_t scale16(uint16_t i, uint16_t scale ) { return ((uint32_t)i * (1 + (uint32_t)scale)) >> 16; }
 __attribute__ ((always_inline)) inline uint8_t  qadd8(uint8_t i, uint8_t j) { unsigned t = i + j; return t > 255 ? 255 : t; }
 __attribute__ ((always_inline)) inline uint8_t  qsub8(uint8_t i, uint8_t j) { int t = i - j; return t < 0 ? 0 : t; }
+__attribute__ ((always_inline)) inline uint8_t  qmul8(uint8_t i, uint8_t j) { unsigned p = (unsigned)i * (unsigned)j; return p > 255 ? 255 : p; }
 __attribute__ ((always_inline)) inline int8_t   abs8(int8_t i) { return i < 0 ? -i : i; }
 __attribute__ ((always_inline)) inline int8_t   lerp8by8(uint8_t a, uint8_t b, uint8_t frac) { return a + ((((int32_t)b - (int32_t)a) * ((int32_t)frac+1)) >> 8); }
 /*