Add Payloads element to harvest bundle payloads.
#636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnson
force-pushed
the
bob/PayloadsHarvesting
branch
from
4e20b89 to
3365bed
Compare
barnson
added
documentation
Member
Author
|
Fixes wixtoolset/issues#9049 |
robmen
previously approved these changes
Jun 11, 2025
barnson
force-pushed
the
bob/PayloadsHarvesting
branch
from
3365bed to
ccf2b7b
Compare
- Handle extra-long paths being normalized to either \\?\\ and "normal." - Rewrite PathGetTempPathTest test because it's not a good test: - By overwriting `TMP` with an extra-long path, it causes `::GetTempPath[2]W` to fall back to the value of `TEMP` instead. - But that's testing `::GetTempPath[2]W`, not `PathGetTempPath`. - It also assumes `TMP` and `TEMP` are set typically. - It also assumes it's not running as LocalSystem. - Instead, just compare the values you get from `::GetTempPathW` and `PathGetTempPath`. Fixes wixtoolset/issues#9087
barnson
force-pushed
the
bob/PayloadsHarvesting
branch
from
76cb522 to
09209f9
Compare
Member
Author
|
@robmen please review the DUtil test fixes, which will unblock everything else... |
robmen
approved these changes
Jun 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements wixtoolset/issues#9049